From: Takashi Iwai <tiwai@suse.de>
To: Zheyu Ma <zheyuma97@gmail.com>
Cc: perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: bcd2000: Fix a UAF bug on the error path of probing
Date: Fri, 15 Jul 2022 08:58:54 +0200 [thread overview]
Message-ID: <87a69ax3o1.wl-tiwai@suse.de> (raw)
In-Reply-To: <20220715010515.2087925-1-zheyuma97@gmail.com>
On Fri, 15 Jul 2022 03:05:15 +0200,
Zheyu Ma wrote:
>
> When the driver fails in snd_card_register() at probe time, it will free
> the 'bcd2k->midi_out_urb' before killing it, which may cause a UAF bug.
>
> The following log can reveal it:
>
> [ 50.727020] BUG: KASAN: use-after-free in bcd2000_input_complete+0x1f1/0x2e0 [snd_bcd2000]
> [ 50.727623] Read of size 8 at addr ffff88810fab0e88 by task swapper/4/0
> [ 50.729530] Call Trace:
> [ 50.732899] bcd2000_input_complete+0x1f1/0x2e0 [snd_bcd2000]
>
> Fix this by adding usb_kill_urb() before usb_free_urb().
>
> Fixes: b47a22290d58 ("ALSA: MIDI driver for Behringer BCD2000 USB device")
> Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
Thanks, applied.
Takashi
prev parent reply other threads:[~2022-07-15 6:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-15 1:05 [PATCH] ALSA: bcd2000: Fix a UAF bug on the error path of probing Zheyu Ma
2022-07-15 6:58 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a69ax3o1.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=zheyuma97@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox