From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A5E5C43334 for ; Sat, 9 Jul 2022 16:27:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229607AbiGIQ1i (ORCPT ); Sat, 9 Jul 2022 12:27:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229469AbiGIQ1h (ORCPT ); Sat, 9 Jul 2022 12:27:37 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5BE002F3BD for ; Sat, 9 Jul 2022 09:27:36 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 199C01FF53; Sat, 9 Jul 2022 16:27:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1657384055; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7uxtvX/a+1MK1A3Gv9mOnjsFc38a4bxWl6LuLZXUfbg=; b=C3PZSrhaXh0JXDE57k3kHWJl/ElK/sHRD2z5Io2DOgb63nftn9gFtro1jfXSFQA+H0iKv3 dqet1CFb4Oh+BmO7LP0WyR9pYGQe/TMbOMx5pnjCdqIyZuDSi7Tmqk6UTOeFsHsBdEASuz 7HOD2yf2wltZEiRjdpTeuSOFSCP5S3g= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1657384055; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7uxtvX/a+1MK1A3Gv9mOnjsFc38a4bxWl6LuLZXUfbg=; b=JAJdUacHTJWPuypLSBNnawJgdZvKNQjyPH6ARwYBOwkJYTcJOHfcEomDrIFSiwfX1vFizk hCCT795zNFt1YkCw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E60C713482; Sat, 9 Jul 2022 16:27:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 3ueJN3asyWKhYwAAMHmgww (envelope-from ); Sat, 09 Jul 2022 16:27:34 +0000 Date: Sat, 09 Jul 2022 18:27:34 +0200 Message-ID: <87a69ii749.wl-tiwai@suse.de> From: Takashi Iwai To: Mark Brown Cc: Vitaly Rodionov , Jaroslav Kysela , Takashi Iwai , , , Subject: Re: [PATCH v8 00/14] ALSA: hda: cirrus: Add initial DSP support and firmware loading In-Reply-To: <87zghpxcsh.wl-tiwai@suse.de> References: <20220630002335.366545-1-vitalyr@opensource.cirrus.com> <87zghpxcsh.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 04 Jul 2022 14:50:06 +0200, Takashi Iwai wrote: > > On Thu, 30 Jun 2022 02:23:21 +0200, > Vitaly Rodionov wrote: > > > > The CS35L41 Amplifier contains a DSP, capable of running firmware. > > The firmware can run algorithms such as Speaker Protection, to ensure > > that playback at high gains do not harm the speakers. > > Adding support for CS35L41 firmware into the CS35L41 HDA driver also > > allows us to support several extra features, such as hiberation > > and interrupts. > > > > The chain adds support in stages: > > - General fixes to improve generalization and code re-use inside > > the CS35L41 HDA driver. > > - Add support for interrupts into the driver, which is required > > for complete support of the firmware. > > - Refactor ASoC CS35L41 code which deals with firmware to allow > > for code re-use inside the CS35L41 HDA driver. > > - Add support for loading firmware and tuning files from file system, > > and creating alsa controls to control it. > > - Support firmware load paths for different hardware systems. > > - Support suspend/resume in the driver when using firmware. The firmware > > supports hibernation, which allows the CS35L41 to drop into a low > > power mode during suspend. > > - Support the ability to unload firmware, swap and reload the firmware. > > This is to allow different firmware to run during calibration. > > > > The intended use-case is to load the firmware once on boot, and the driver > > autmatically tries to load the firmware after it binds to the HDA driver. > > This behaviour can be switched off using a kconfig, if desired. > > > > changes since v7: > > - Use private_data rather than private_value to save control info > > - Clean up alsa control memory allocation/deallocation > > - Remove unnecessary whitespace > > - Get subsystem id from codec, rather than saving it separately > > > > changes since v6: > > - Fix warning by kernel test robot > > > > changes since v5: > > - Fix warning by kernel test robot > > > > changes since v4: > > - Fully remove tlv remnants from control add apis > > - Remove unnecessary debug > > - Rename variable to be more generic > > - Remove redundent length check from read/write control apis > > > > > > - Use SNDRV_CTL_ELEM_IFACE_CARD for firmware load controls > > - Make kcontrol add/remove synchronous > > - Load firmware asynchronous when loading via control > > - Used cached controls when reloading firmware; only delete > > controls when removing the driver itself > > > > > > - Improve kcontrol remove > > - Fix control write + notify > > - Cleanup of unnecessary code > > - Fix race condition when loading firmware before playback > > - Ensure errors are properly propogated > > - Fix include for Module parameters > > > > Stefan Binding (13): > > ALSA: hda: hda_cs_dsp_ctl: Add Library to support CS_DSP ALSA controls > > ALSA: hda: hda_cs_dsp_ctl: Add apis to write the controls directly > > ALSA: hda: cs35l41: Save codec object inside component struct > > ALSA: hda: cs35l41: Save Subsystem ID inside CS35L41 Driver > > ALSA: hda: cs35l41: Support reading subsystem id from ACPI > > ALSA: hda: cs35l41: Support multiple load paths for firmware > > ALSA: hda: cs35l41: Support Speaker ID for laptops > > ALSA: hda: cs35l41: Support Hibernation during Suspend > > ALSA: hda: cs35l41: Read Speaker Calibration data from UEFI variables > > ALSA: hda: hda_cs_dsp_ctl: Add fw id strings > > ALSA: hda: cs35l41: Add defaulted values into dsp bypass config > > sequence > > ALSA: hda: cs35l41: Support Firmware switching and reloading > > ALSA: hda: cs35l41: Add module parameter to control firmware load > > > > Vitaly Rodionov (1): > > ALSA: hda: cs35l41: Add initial DSP support and firmware loading > > Thanks, this version looks better than previous ones, and I'm fine to > apply as is, to make things going forward. But this seems requiring > the prerequisite in ASoC codec side. > > Mark, could you send a PR to merge into my tree so that I can apply > those series? Mark? This series need the ASoC for-next change as prerequisite. thanks, Takashi