From: Marc Zyngier <maz@kernel.org>
To: Miaoqian Lin <linmq006@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] irqchip/gic/realview: Fix refcount leak in realview_gic_of_init
Date: Thu, 26 May 2022 14:17:04 +0100 [thread overview]
Message-ID: <87a6b4mo1b.wl-maz@kernel.org> (raw)
In-Reply-To: <20220526074348.23972-1-linmq006@gmail.com>
On Thu, 26 May 2022 08:43:48 +0100,
Miaoqian Lin <linmq006@gmail.com> wrote:
>
> of_find_matching_node_and_match() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when not need anymore.
> Add missing of_node_put() to avoid refcount leak.
>
> Fixes: 82b0a434b436 ("irqchip/gic/realview: Support more RealView DCC variants")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Instead of sending these one after the other, why don't you send a
series addressing the irqchip drivers in one go? That'd be much easier
to manage and review.
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2022-05-26 13:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-26 7:43 [PATCH] irqchip/gic/realview: Fix refcount leak in realview_gic_of_init Miaoqian Lin
2022-05-26 13:17 ` Marc Zyngier [this message]
2022-05-26 14:34 ` Miaoqian Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6b4mo1b.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=linmq006@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox