[PATCH] irqchip/gic/realview: Fix refcount leak in realview_gic_of_init

[PATCH] irqchip/gic/realview: Fix refcount leak in realview_gic_of_init

[Miaoqian Lin]

of_find_matching_node_and_match() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.

Fixes: 82b0a434b436 ("irqchip/gic/realview: Support more RealView DCC variants")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
 drivers/irqchip/irq-gic-realview.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/irqchip/irq-gic-realview.c b/drivers/irqchip/irq-gic-realview.c
index b4c1924f0255..38fab02ffe9d 100644
--- a/drivers/irqchip/irq-gic-realview.c
+++ b/drivers/irqchip/irq-gic-realview.c
@@ -57,6 +57,7 @@ realview_gic_of_init(struct device_node *node, struct device_node *parent)
 
 	/* The PB11MPCore GIC needs to be configured in the syscon */
 	map = syscon_node_to_regmap(np);
+	of_node_put(np);
 	if (!IS_ERR(map)) {
 		/* new irq mode with no DCC */
 		regmap_write(map, REALVIEW_SYS_LOCK_OFFSET,
-- 
2.25.1

Re: [PATCH] irqchip/gic/realview: Fix refcount leak in realview_gic_of_init

[Marc Zyngier]

On Thu, 26 May 2022 08:43:48 +0100,
Miaoqian Lin <linmq006@gmail.com> wrote:
> 
> of_find_matching_node_and_match() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when not need anymore.
> Add missing of_node_put() to avoid refcount leak.
> 
> Fixes: 82b0a434b436 ("irqchip/gic/realview: Support more RealView DCC variants")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>

Instead of sending these one after the other, why don't you send a
series addressing the irqchip drivers in one go? That'd be much easier
to manage and review.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.

Re: [PATCH] irqchip/gic/realview: Fix refcount leak in realview_gic_of_init

[Miaoqian Lin]

On 2022/5/26 21:17, Marc Zyngier wrote:
> On Thu, 26 May 2022 08:43:48 +0100,
> Miaoqian Lin <linmq006@gmail.com> wrote:
>> of_find_matching_node_and_match() returns a node pointer with refcount
>> incremented, we should use of_node_put() on it when not need anymore.
>> Add missing of_node_put() to avoid refcount leak.
>>
>> Fixes: 82b0a434b436 ("irqchip/gic/realview: Support more RealView DCC variants")
>> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> Instead of sending these one after the other, why don't you send a
> series addressing the irqchip drivers in one go? That'd be much easier
> to manage and review.

Hi, Marc

Thanks for your suggestion, I will do that.

> Thanks,
>
> 	M.
>