From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51A21C433F5 for ; Thu, 26 May 2022 13:17:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244930AbiEZNRO (ORCPT ); Thu, 26 May 2022 09:17:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230010AbiEZNRL (ORCPT ); Thu, 26 May 2022 09:17:11 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 923FDC5E77 for ; Thu, 26 May 2022 06:17:10 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2D10C61ABC for ; Thu, 26 May 2022 13:17:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 814A3C385A9; Thu, 26 May 2022 13:17:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653571029; bh=IJHWboOnB04oHPuvgwG0K7Zt4XEO7o5G9M1ZTH5c6X8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=eQlWDxCcbZSDY9JK7nfARh0P0yqN/W0Ux42ErqPoTa1r5zhukTECqy2e+xtcPsTUX ErLO+VC0FJCNG9evSBjqxB0/4pidSGcy9vCamtc8dZqdhh5zXVOoNvcx5/cQNAOjHS k5nKLlK+mq1D5NU+zPHu4Ce+2+UJeAWz0HXtfvUjLKbPRH31B6A7vmukq2XTHKNjXl UCXbS/2iNKWaJAxMCyot+mvsd/0wsmmNjEK2WFiMsOIt6xpFMt/wKYg1FPPa3YzleK BP45oufEdhLXBJ3Yb5Ng/9njjXy2mD8YZcSW4OIolcFZGadrtm9Jyb8ynS1r/g4QdW omlZx3nRRaUqA== Received: from athedsl-4557779.home.otenet.gr ([94.70.87.219] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nuDMR-00Dr95-2R; Thu, 26 May 2022 14:17:07 +0100 Date: Thu, 26 May 2022 14:17:04 +0100 Message-ID: <87a6b4mo1b.wl-maz@kernel.org> From: Marc Zyngier To: Miaoqian Lin Cc: Thomas Gleixner , Linus Walleij , linux-kernel@vger.kernel.org Subject: Re: [PATCH] irqchip/gic/realview: Fix refcount leak in realview_gic_of_init In-Reply-To: <20220526074348.23972-1-linmq006@gmail.com> References: <20220526074348.23972-1-linmq006@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 94.70.87.219 X-SA-Exim-Rcpt-To: linmq006@gmail.com, tglx@linutronix.de, linus.walleij@linaro.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 26 May 2022 08:43:48 +0100, Miaoqian Lin wrote: > > of_find_matching_node_and_match() returns a node pointer with refcount > incremented, we should use of_node_put() on it when not need anymore. > Add missing of_node_put() to avoid refcount leak. > > Fixes: 82b0a434b436 ("irqchip/gic/realview: Support more RealView DCC variants") > Signed-off-by: Miaoqian Lin Instead of sending these one after the other, why don't you send a series addressing the irqchip drivers in one go? That'd be much easier to manage and review. Thanks, M. -- Without deviation from the norm, progress is not possible.