* [PATCH] irqchip/gic/realview: Fix refcount leak in realview_gic_of_init
@ 2022-05-26 7:43 Miaoqian Lin
2022-05-26 13:17 ` Marc Zyngier
0 siblings, 1 reply; 3+ messages in thread
From: Miaoqian Lin @ 2022-05-26 7:43 UTC (permalink / raw)
To: Thomas Gleixner, Marc Zyngier, Linus Walleij, linux-kernel; +Cc: linmq006
of_find_matching_node_and_match() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.
Fixes: 82b0a434b436 ("irqchip/gic/realview: Support more RealView DCC variants")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/irqchip/irq-gic-realview.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/irqchip/irq-gic-realview.c b/drivers/irqchip/irq-gic-realview.c
index b4c1924f0255..38fab02ffe9d 100644
--- a/drivers/irqchip/irq-gic-realview.c
+++ b/drivers/irqchip/irq-gic-realview.c
@@ -57,6 +57,7 @@ realview_gic_of_init(struct device_node *node, struct device_node *parent)
/* The PB11MPCore GIC needs to be configured in the syscon */
map = syscon_node_to_regmap(np);
+ of_node_put(np);
if (!IS_ERR(map)) {
/* new irq mode with no DCC */
regmap_write(map, REALVIEW_SYS_LOCK_OFFSET,
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] irqchip/gic/realview: Fix refcount leak in realview_gic_of_init
2022-05-26 7:43 [PATCH] irqchip/gic/realview: Fix refcount leak in realview_gic_of_init Miaoqian Lin
@ 2022-05-26 13:17 ` Marc Zyngier
2022-05-26 14:34 ` Miaoqian Lin
0 siblings, 1 reply; 3+ messages in thread
From: Marc Zyngier @ 2022-05-26 13:17 UTC (permalink / raw)
To: Miaoqian Lin; +Cc: Thomas Gleixner, Linus Walleij, linux-kernel
On Thu, 26 May 2022 08:43:48 +0100,
Miaoqian Lin <linmq006@gmail.com> wrote:
>
> of_find_matching_node_and_match() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when not need anymore.
> Add missing of_node_put() to avoid refcount leak.
>
> Fixes: 82b0a434b436 ("irqchip/gic/realview: Support more RealView DCC variants")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Instead of sending these one after the other, why don't you send a
series addressing the irqchip drivers in one go? That'd be much easier
to manage and review.
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] irqchip/gic/realview: Fix refcount leak in realview_gic_of_init
2022-05-26 13:17 ` Marc Zyngier
@ 2022-05-26 14:34 ` Miaoqian Lin
0 siblings, 0 replies; 3+ messages in thread
From: Miaoqian Lin @ 2022-05-26 14:34 UTC (permalink / raw)
To: Marc Zyngier; +Cc: Thomas Gleixner, Linus Walleij, linux-kernel
On 2022/5/26 21:17, Marc Zyngier wrote:
> On Thu, 26 May 2022 08:43:48 +0100,
> Miaoqian Lin <linmq006@gmail.com> wrote:
>> of_find_matching_node_and_match() returns a node pointer with refcount
>> incremented, we should use of_node_put() on it when not need anymore.
>> Add missing of_node_put() to avoid refcount leak.
>>
>> Fixes: 82b0a434b436 ("irqchip/gic/realview: Support more RealView DCC variants")
>> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> Instead of sending these one after the other, why don't you send a
> series addressing the irqchip drivers in one go? That'd be much easier
> to manage and review.
Hi, Marc
Thanks for your suggestion, I will do that.
> Thanks,
>
> M.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-26 14:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-26 7:43 [PATCH] irqchip/gic/realview: Fix refcount leak in realview_gic_of_init Miaoqian Lin
2022-05-26 13:17 ` Marc Zyngier
2022-05-26 14:34 ` Miaoqian Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox