From: Andreas Schwab <schwab@linux-m68k.org>
To: Palmer Dabbelt <palmer@rivosinc.com>
Cc: linux-riscv@lists.infradead.org, rdunlap@infradead.org,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
aou@eecs.berkeley.edu, anup@brainfault.org,
vincent.chen@sifive.com, guoren@kernel.org,
Atish Patra <atishp@rivosinc.com>,
alexandre.ghiti@canonical.com, jszhang@kernel.org,
vitaly.wool@konsulko.com, gatecat@ds0.me,
wangkefeng.wang@huawei.com, mick@ics.forth.gr,
panqinglin2020@iscas.ac.cn, rppt@kernel.org,
linux-kernel@vger.kernel.org, linux@rivosinc.com,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v2 1/4] RISC-V: Avoid empty create_*_mapping definitions
Date: Thu, 21 Apr 2022 00:11:37 +0200 [thread overview]
Message-ID: <87a6cfh0bq.fsf@igel.home> (raw)
In-Reply-To: <20220420184056.7886-2-palmer@rivosinc.com> (Palmer Dabbelt's message of "Wed, 20 Apr 2022 11:40:53 -0700")
On Apr 20 2022, Palmer Dabbelt wrote:
> (create_pmd_mpping() ends up skipped on XIP_KERNEL).
Does it? There is always the semicolon left as the body of the
conditional (which is why you get the empty-body warning in the first
place).
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
next prev parent reply other threads:[~2022-04-20 22:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 18:40 [PATCH v2 0/4] RISC-V: Various XIP fixes Palmer Dabbelt
2022-04-20 18:40 ` [PATCH v2 1/4] RISC-V: Avoid empty create_*_mapping definitions Palmer Dabbelt
2022-04-20 22:11 ` Andreas Schwab [this message]
2022-05-25 21:32 ` Palmer Dabbelt
2022-04-20 18:40 ` [PATCH v2 2/4] RISC-V: ignore xipImage Palmer Dabbelt
2022-04-21 6:26 ` Guo Ren
2022-04-20 18:40 ` [PATCH v2 3/4] RISC-V: Split out the XIP fixups into their own file Palmer Dabbelt
2022-04-21 6:45 ` Guo Ren
2022-05-25 21:45 ` Palmer Dabbelt
2022-04-20 18:40 ` [PATCH v2 4/4] RISC-V: Fix the XIP build Palmer Dabbelt
2022-04-21 6:46 ` Guo Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6cfh0bq.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=alexandre.ghiti@canonical.com \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=atishp@rivosinc.com \
--cc=gatecat@ds0.me \
--cc=guoren@kernel.org \
--cc=jszhang@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux@rivosinc.com \
--cc=lkp@intel.com \
--cc=mick@ics.forth.gr \
--cc=palmer@dabbelt.com \
--cc=palmer@rivosinc.com \
--cc=panqinglin2020@iscas.ac.cn \
--cc=paul.walmsley@sifive.com \
--cc=rdunlap@infradead.org \
--cc=rppt@kernel.org \
--cc=vincent.chen@sifive.com \
--cc=vitaly.wool@konsulko.com \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox