* [PATCH] drm/i915/vlv_dsi_pll: use min_t() to make code cleaner
@ 2022-03-08 9:16 cgel.zte
2022-03-09 8:46 ` Jani Nikula
0 siblings, 1 reply; 2+ messages in thread
From: cgel.zte @ 2022-03-08 9:16 UTC (permalink / raw)
To: joonas.lahtinen
Cc: rodrigo.vivi, tvrtko.ursulin, airlied, daniel, ville.syrjala,
hdegoede, lucas.demarchi, deng.changcheng, intel-gfx, dri-devel,
linux-kernel, Zeal Robot
From: Changcheng Deng <deng.changcheng@zte.com.cn>
Use min_t() in order to make code cleaner.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
---
drivers/gpu/drm/i915/display/vlv_dsi_pll.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/vlv_dsi_pll.c b/drivers/gpu/drm/i915/display/vlv_dsi_pll.c
index df880f44700a..f801f7ec3f9a 100644
--- a/drivers/gpu/drm/i915/display/vlv_dsi_pll.c
+++ b/drivers/gpu/drm/i915/display/vlv_dsi_pll.c
@@ -393,10 +393,7 @@ static void glk_dsi_program_esc_clock(struct drm_device *dev,
/* Calculate TXESC2 divider */
div2_value = DIV_ROUND_UP(div1_value, txesc1_div);
- if (div2_value < 10)
- txesc2_div = div2_value;
- else
- txesc2_div = 10;
+ txesc2_div = min_t(u32, div2_value, 10);
intel_de_write(dev_priv, MIPIO_TXESC_CLK_DIV1,
(1 << (txesc1_div - 1)) & GLK_TX_ESC_CLK_DIV1_MASK);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/i915/vlv_dsi_pll: use min_t() to make code cleaner
2022-03-08 9:16 [PATCH] drm/i915/vlv_dsi_pll: use min_t() to make code cleaner cgel.zte
@ 2022-03-09 8:46 ` Jani Nikula
0 siblings, 0 replies; 2+ messages in thread
From: Jani Nikula @ 2022-03-09 8:46 UTC (permalink / raw)
To: cgel.zte, joonas.lahtinen
Cc: tvrtko.ursulin, airlied, intel-gfx, lucas.demarchi,
deng.changcheng, dri-devel, linux-kernel, hdegoede, rodrigo.vivi,
Zeal Robot
On Tue, 08 Mar 2022, cgel.zte@gmail.com wrote:
> From: Changcheng Deng <deng.changcheng@zte.com.cn>
>
> Use min_t() in order to make code cleaner.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
Thanks, pushed to drm-intel-next.
BR,
Jani.
> ---
> drivers/gpu/drm/i915/display/vlv_dsi_pll.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/vlv_dsi_pll.c b/drivers/gpu/drm/i915/display/vlv_dsi_pll.c
> index df880f44700a..f801f7ec3f9a 100644
> --- a/drivers/gpu/drm/i915/display/vlv_dsi_pll.c
> +++ b/drivers/gpu/drm/i915/display/vlv_dsi_pll.c
> @@ -393,10 +393,7 @@ static void glk_dsi_program_esc_clock(struct drm_device *dev,
> /* Calculate TXESC2 divider */
> div2_value = DIV_ROUND_UP(div1_value, txesc1_div);
>
> - if (div2_value < 10)
> - txesc2_div = div2_value;
> - else
> - txesc2_div = 10;
> + txesc2_div = min_t(u32, div2_value, 10);
>
> intel_de_write(dev_priv, MIPIO_TXESC_CLK_DIV1,
> (1 << (txesc1_div - 1)) & GLK_TX_ESC_CLK_DIV1_MASK);
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-09 8:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-08 9:16 [PATCH] drm/i915/vlv_dsi_pll: use min_t() to make code cleaner cgel.zte
2022-03-09 8:46 ` Jani Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox