Re: [RFC PATCH 1/4] stop_machine: Move cpu_stop_done into stop_machine.h

Yafang Shao
2021-11-06T07:35:02Z

On Sat, Nov 6, 2021 at 1:01 AM Valentin Schneider
<valentin.schneider@arm.com> wrote:
>
> On 04/11/21 14:57, Yafang Shao wrote:
> > Move struct cpu_stop_done into the stop_machine.h, then it can be resued
> > by the functions outside of stop_maichine.c.
> >
>
> The nr_todo & ret faff is only required for multi_stop scenarios, which
> isn't your use-case. AFAICT you don't need to export this, you just need a
> struct completion somewhere (and maybe a ret, but I'm not even sure about
> that).

Right. nr_todo is for stopping two and more cpus. We really don't
need it if we only support stopping one cpu.
I will change it.

--
Thanks
Yafang