From: Thomas Gleixner <tglx@linutronix.de>
To: Zhen Lei <thunder.leizhen@huawei.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Cc: Zhen Lei <thunder.leizhen@huawei.com>
Subject: Re: [PATCH 1/1] genirq/timings: Fix error return code in irq_timings_test_irqs()
Date: Tue, 10 Aug 2021 15:33:36 +0200 [thread overview]
Message-ID: <87a6lps9u7.ffs@tglx> (raw)
In-Reply-To: <20210508062043.2524-1-thunder.leizhen@huawei.com>
On Sat, May 08 2021 at 14:20, Zhen Lei wrote:
> Fix to return a negative error code from the error handling case instead
> of 0, as done elsewhere in this function.
Returning an error code is fine, but
>
> __irq_timings_store(irq, irqs, ti->intervals[i]);
> if (irqs->circ_timings[i & IRQ_TIMINGS_MASK] != index) {
> + ret = -EFAULT;
EFAULT is really not appropriate here. EFAULT is used for mapping
faults. ENOSPC or EBADSLT perhaps?
> pr_err("Failed to store in the circular buffer\n");
> goto out;
> }
> }
>
> if (irqs->count != ti->count) {
> + ret = -EFAULT;
ERANGE?
Thanks,
tglx
next prev parent reply other threads:[~2021-08-10 13:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-08 6:20 [PATCH 1/1] genirq/timings: Fix error return code in irq_timings_test_irqs() Zhen Lei
2021-08-10 13:33 ` Thomas Gleixner [this message]
2021-08-11 7:11 ` Leizhen (ThunderTown)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6lps9u7.ffs@tglx \
--to=tglx@linutronix.de \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thunder.leizhen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox