From: ebiederm@xmission.com (Eric W. Biederman)
To: <linux-kernel@vger.kernel.org>
Cc: <linux-fsdevel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>, Jann Horn <jannh@google.com>,
Kees Cook <keescook@chromium.org>,
Bernd Edlinger <bernd.edlinger@hotmail.de>
Subject: [PATCH v2 3/6] signal: Implement SIGNAL_GROUP_DETHREAD
Date: Tue, 23 Jun 2020 16:54:43 -0500 [thread overview]
Message-ID: <87a70tla70.fsf_-_@x220.int.ebiederm.org> (raw)
In-Reply-To: <87r1u5laac.fsf@x220.int.ebiederm.org> (Eric W. Biederman's message of "Tue, 23 Jun 2020 16:52:43 -0500")
To allow signal_group_exit to be simplfied so that it can only test
signal->flags. Add a new flag SIGNAL_GROUP_DETHREAD, that is set and
cleared where de_thread sets and clears group_exit_task today.
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
---
fs/exec.c | 3 +++
include/linux/sched/signal.h | 1 +
2 files changed, 4 insertions(+)
diff --git a/fs/exec.c b/fs/exec.c
index 33b5d9229c01..9c4c1ab8f715 100644
--- a/fs/exec.c
+++ b/fs/exec.c
@@ -1145,6 +1145,7 @@ static int de_thread(struct task_struct *tsk)
return -EAGAIN;
}
+ sig->flags |= SIGNAL_GROUP_DETHREAD;
sig->group_exit_task = tsk;
sig->notify_count = zap_other_threads(tsk);
if (!thread_group_leader(tsk))
@@ -1244,6 +1245,7 @@ static int de_thread(struct task_struct *tsk)
}
spin_lock_irq(lock);
+ sig->flags &= ~SIGNAL_GROUP_DETHREAD;
sig->group_exit_task = NULL;
sig->notify_count = 0;
spin_unlock_irq(lock);
@@ -1259,6 +1261,7 @@ static int de_thread(struct task_struct *tsk)
/* protects against exit_notify() and __exit_signal() */
read_lock_irq(&tasklist_lock);
spin_lock(lock);
+ sig->flags &= ~SIGNAL_GROUP_DETHREAD;
sig->group_exit_task = NULL;
sig->notify_count = 0;
spin_unlock(lock);
diff --git a/include/linux/sched/signal.h b/include/linux/sched/signal.h
index b4f36a11be5e..5ff8697b21cd 100644
--- a/include/linux/sched/signal.h
+++ b/include/linux/sched/signal.h
@@ -253,6 +253,7 @@ struct signal_struct {
/* Signal group actions. */
#define SIGNAL_GROUP_EXIT 0x00000100 /* group exit in progress */
#define SIGNAL_GROUP_COREDUMP 0x00000200 /* coredump in progress */
+#define SIGNAL_GROUP_DETHREAD 0x00000400 /* exec de_thread in progress */
/* Flags applicable to the entire signal group. */
#define SIGNAL_UNKILLABLE 0x00001000 /* for init: ignore fatal signals */
--
2.20.1
next prev parent reply other threads:[~2020-06-23 21:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 18:30 [PATCH 0/2] exec: s/group_exit_task/group_exec_task/ for clarity Eric W. Biederman
2020-06-19 18:32 ` [PATCH 1/2] exec: Don't set group_exit_task during a coredump Eric W. Biederman
2020-06-20 18:58 ` Linus Torvalds
2020-06-22 16:20 ` Eric W. Biederman
2020-06-22 16:32 ` Linus Torvalds
2020-06-22 11:25 ` Oleg Nesterov
2020-06-19 18:33 ` [PATCH 2/2] exec: Rename group_exit_task group_exec_task and correct the Documentation Eric W. Biederman
2020-06-23 21:52 ` [PATCH v2 0/6] exec: s/group_exit_task/group_exec_task/ for clarity Eric W. Biederman
2020-06-23 21:53 ` [PATCH v2 1/6] signal: Pretty up the SIGNAL_GROUP_FLAGS Eric W. Biederman
2020-06-23 21:54 ` [PATCH v2 2/6] exec: Lock more defensively in exec Eric W. Biederman
2020-06-23 21:54 ` Eric W. Biederman [this message]
2020-06-23 21:55 ` [PATCH v2 4/6] signal: In signal_group_exit remove the group_exit_task test Eric W. Biederman
2020-06-23 21:55 ` [PATCH v2 5/6] coredump: Stop using group_exit_task Eric W. Biederman
2020-06-23 21:56 ` [PATCH v2 6/6] exec: Rename group_exit_task group_exec_task and correct the Documentation Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a70tla70.fsf_-_@x220.int.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=bernd.edlinger@hotmail.de \
--cc=jannh@google.com \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox