From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7867C0044C for ; Wed, 31 Oct 2018 15:13:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5BB1A2064C for ; Wed, 31 Oct 2018 15:13:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5BB1A2064C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728048AbeKAAMC (ORCPT ); Wed, 31 Oct 2018 20:12:02 -0400 Received: from mga06.intel.com ([134.134.136.31]:20118 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726686AbeKAAMC (ORCPT ); Wed, 31 Oct 2018 20:12:02 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Oct 2018 08:13:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,447,1534834800"; d="scan'208";a="104142627" Received: from ksmole-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.40.70]) by fmsmga001.fm.intel.com with ESMTP; 31 Oct 2018 08:13:33 -0700 From: Jani Nikula To: Shayenne da Luz Moura , Maarten Lankhorst , Maxime Ripard , Sean Paul , David Airlie Cc: outreachy-kernel@googlegroups.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm: Remove 80-column line in drm_mode_object.c In-Reply-To: <20181031144445.vrdngzj3jclforta@smtp.gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20181031144445.vrdngzj3jclforta@smtp.gmail.com> Date: Wed, 31 Oct 2018 17:13:38 +0200 Message-ID: <87a7mudu8t.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 31 Oct 2018, Shayenne da Luz Moura wrote: > Add a new variable to make the drm_mode_object comparison before > idr_alloc and decrease line size. > > Signed-off-by: Shayenne da Luz Moura > --- > drivers/gpu/drm/drm_mode_object.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_mode_object.c b/drivers/gpu/drm/drm_mode_object.c > index be8b754eaf60..4b9eafddb409 100644 > --- a/drivers/gpu/drm/drm_mode_object.c > +++ b/drivers/gpu/drm/drm_mode_object.c > @@ -36,9 +36,10 @@ int __drm_mode_object_add(struct drm_device *dev, struct drm_mode_object *obj, > void (*obj_free_cb)(struct kref *kref)) > { > int ret; > + struct drm_mode_object *obj_tmp = register_obj ? obj : NULL; > > mutex_lock(&dev->mode_config.idr_mutex); > - ret = idr_alloc(&dev->mode_config.crtc_idr, register_obj ? obj : NULL, 1, 0, GFP_KERNEL); > + ret = idr_alloc(&dev->mode_config.crtc_idr, obj_tmp, 1, 0, GFP_KERNEL); Please don't send checkpatch "fixes" to adhere to the 80-column rule. Or at least use --max-line-length=100 or something to look for worse offenders than this. And if you insist, please just add a newline and proper indentation after "NULL," instead of adding a temporary variable. BR, Jani. > if (ret >= 0) { > /* > * Set up the object linking under the protection of the idr -- Jani Nikula, Intel Open Source Graphics Center