From: Eric Anholt <eric@anholt.net>
To: Stefan Wahren <stefan.wahren@i2se.com>,
Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi>,
phil@raspberrypi.org
Cc: linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-rpi-kernel@lists.infradead.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH 0/7] staging: vc04_services: Some dead code removal
Date: Mon, 15 Oct 2018 09:14:34 -0700 [thread overview]
Message-ID: <87a7nf5gr9.fsf@anholt.net> (raw)
In-Reply-To: <1715113043.52878.1538821118324@email.1und1.de>
[-- Attachment #1: Type: text/plain, Size: 1149 bytes --]
Stefan Wahren <stefan.wahren@i2se.com> writes:
> Hi Tuomas,
>
>> Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi> hat am 4. Oktober 2018 um 11:37 geschrieben:
>>
>>
>> Drop various pieces of dead code from here and there to get rid of
>> the remaining users of VCHI_CONNECTION_T. After that we get to drop
>> entire header files worth of unused code.
>>
>> I've tested on a Raspberry Pi Model B (bcm2835_defconfig) that
>> snd-bcm2835 can still play analog audio just fine.
>>
>
> thanks and i'm fine with your patch series:
>
> Acked-by: Stefan Wahren <stefan.wahren@i2se.com>
>
> Unfortunately this would break compilation of the downstream vchi
> drivers like vcsm [1]. Personally i don't want to maintain another
> one, because i cannot see the gain of the resulting effort.
>
> [1] - https://github.com/raspberrypi/linux/tree/rpi-4.14.y/drivers/char/broadcom/vc_sm
I think the main concern would be if we removed things necessary for
6by9's new vcsm (the one that will let us do dma-buf sharing between
media decode and DRM).
On the other hand, git revert is a thing, so it's not like we actually
lose anything.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2018-10-15 16:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 9:37 [PATCH 0/7] staging: vc04_services: Some dead code removal Tuomas Tynkkynen
2018-10-04 9:37 ` [PATCH 1/7] staging: vc04_services: Drop pointless stub functions Tuomas Tynkkynen
2018-10-04 9:37 ` [PATCH 2/7] staging: vc04_services: Drop 'connection' field from SERVICE_CREATION_T Tuomas Tynkkynen
2018-10-04 9:37 ` [PATCH 3/7] staging: vc04_services: Drop trivially unused fields " Tuomas Tynkkynen
2018-10-04 9:37 ` [PATCH 4/7] staging: vc04_services: Drop declaration of vchi_crc_control() Tuomas Tynkkynen
2018-10-04 9:37 ` [PATCH 5/7] staging: vc04_services: Drop VCHI_SERVICE_INIT and SERVICE_INFO_T Tuomas Tynkkynen
2018-10-04 9:37 ` [PATCH 6/7] staging: vc04_services: Drop unused parameters from vchi_connect() Tuomas Tynkkynen
2018-10-04 9:37 ` [PATCH 7/7] staging: vc04_services: Drop no longer needed headers Tuomas Tynkkynen
2018-10-06 10:18 ` [PATCH 0/7] staging: vc04_services: Some dead code removal Stefan Wahren
2018-10-15 16:14 ` Eric Anholt [this message]
2018-10-17 9:55 ` Dave Stevenson
2018-10-17 10:50 ` Stefan Wahren
2018-10-17 10:18 ` Dan Carpenter
2018-10-17 15:37 ` Eric Anholt
2018-10-17 16:51 ` Peter Robinson
2018-10-18 9:22 ` Dave Stevenson
2018-10-18 9:37 ` Stefan Wahren
2018-10-26 17:15 ` Dave Stevenson
2018-10-28 8:31 ` Stefan Wahren
2018-10-29 10:43 ` Dave Stevenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7nf5gr9.fsf@anholt.net \
--to=eric@anholt.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=phil@raspberrypi.org \
--cc=stefan.wahren@i2se.com \
--cc=tuomas.tynkkynen@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox