From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755658AbdELCSj (ORCPT ); Thu, 11 May 2017 22:18:39 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:40864 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751407AbdELCSi (ORCPT ); Thu, 11 May 2017 22:18:38 -0400 From: Stewart Smith To: Madhavan Srinivasan , Daniel Axtens , Anju T Sudhakar , mpe@ellerman.id.au Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, ego@linux.vnet.ibm.com, bsingharora@gmail.com, anton@samba.org, sukadev@linux.vnet.ibm.com, mikey@neuling.org, eranian@google.com, hemant@linux.vnet.ibm.com Subject: Re: [PATCH v8 05/10] powerpc/perf: IMC pmu cpumask and cpuhotplug support In-Reply-To: <0dfc6438-374c-3086-3847-832b5396e7f2@linux.vnet.ibm.com> References: <1493907596-11425-1-git-send-email-anju@linux.vnet.ibm.com> <1493907596-11425-6-git-send-email-anju@linux.vnet.ibm.com> <87shkfqvx6.fsf@possimpible.ozlabs.ibm.com> <0dfc6438-374c-3086-3847-832b5396e7f2@linux.vnet.ibm.com> User-Agent: Notmuch/0.21+24~gbceb651 (http://notmuchmail.org) Emacs/25.2.1 (x86_64-redhat-linux-gnu) Date: Fri, 12 May 2017 12:18:29 +1000 MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 x-cbid: 17051202-0036-0000-0000-00000203921E X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007049; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000211; SDB=6.00859296; UDB=6.00425929; IPR=6.00638879; BA=6.00005345; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00015419; XFM=3.00000015; UTC=2017-05-12 02:18:34 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17051202-0037-0000-0000-0000404E6FB3 Message-Id: <87a86iizre.fsf@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-05-12_01:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1705120044 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Madhavan Srinivasan writes: >> * in patch 9 should opal_imc_counters_init return something other >> than OPAL_SUCCESS in the case on invalid arguments? Maybe >> OPAL_PARAMETER? (I think you fix this in a later patch anyway?) > > So, init call will return OPAL_PARAMETER for the unsupported > domains (core and nest are supported). And if the init operation > fails for any reason, it would return OPAL_HARDWARE. And this is > documented. (I'll comment on the skiboot one too), but I think that if the class exists but init is a no-op, then OPAL_IMC_COUNTERS_INIT should return OPAL_SUCCESS and just do nothing. This future proofs everything, and the API is that one *must* call _INIT before start. -- Stewart Smith OPAL Architect, IBM.