From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752999AbdBNKmp (ORCPT ); Tue, 14 Feb 2017 05:42:45 -0500 Received: from ozlabs.org ([103.22.144.67]:47895 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752301AbdBNKl5 (ORCPT ); Tue, 14 Feb 2017 05:41:57 -0500 From: Michael Ellerman To: Ravi Bangoria , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Cc: benh@kernel.crashing.org, paulus@samba.org, lsorense@csclub.uwaterloo.ca, oohall@gmail.com, naveen.n.rao@linux.vnet.ibm.com, ast@kernel.org, chris@distroguy.com, aneesh.kumar@linux.vnet.ibm.com, bsingharora@gmail.com, anton@samba.org, paul.gortmaker@windriver.com, bauerman@linux.vnet.ibm.com, viro@zeniv.linux.org.uk, christophe.leroy@c-s.fr, duwe@lst.de, oss@buserror.net, Ravi Bangoria Subject: Re: [PATCH v3 2/2] powerpc: emulate_step tests for load/store instructions In-Reply-To: <1487063803-10848-3-git-send-email-ravi.bangoria@linux.vnet.ibm.com> References: <1487063803-10848-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com> <1487063803-10848-3-git-send-email-ravi.bangoria@linux.vnet.ibm.com> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Tue, 14 Feb 2017 21:41:53 +1100 Message-ID: <87a89pm4um.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ravi Bangoria writes: > diff --git a/arch/powerpc/kernel/kprobes.c b/arch/powerpc/kernel/kprobes.c > index fce05a3..5c5ae66 100644 > --- a/arch/powerpc/kernel/kprobes.c > +++ b/arch/powerpc/kernel/kprobes.c > @@ -528,6 +528,8 @@ int __kprobes longjmp_break_handler(struct kprobe *p, struct pt_regs *regs) > > int __init arch_init_kprobes(void) > { > + test_emulate_step(); > + I don't see any good reason why this is called from here. So I'm inclined to just make test_emulate_step() a regular init call. cheers