From: ebiederm@xmission.com (Eric W. Biederman)
To: "Michael Kerrisk \(man-pages\)" <mtk.manpages@gmail.com>
Cc: "Serge E. Hallyn" <serge@hallyn.com>,
Linux API <linux-api@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
"linux-fsdevel\@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
Andrey Vagin <avagin@openvz.org>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
"W. Trevor King" <wking@tremily.us>,
Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH v2 0/2] Add further ioctl() operations for namespace discovery
Date: Wed, 25 Jan 2017 11:41:42 +1300 [thread overview]
Message-ID: <87a8aggjx5.fsf@xmission.com> (raw)
In-Reply-To: <CAKgNAkimuGpJ1MzLs3wexU+tJakX07Kj_1c+bnGjgk3zgDUGLg@mail.gmail.com> (Michael Kerrisk's message of "Wed, 25 Jan 2017 10:34:18 +1300")
"Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com> writes:
> Hi Eric,
>
> Do you have any input for this small patch set? I've still to tweak a
> comment as suggested by Trevor King, but otherwise I'd like to know if
> this is good to go for the next merge window.
Apologies I have been bogged down with other things. Basically the
code looks fine, and now that I have caught up with things I will be
happy to merge your for the next merge window.
I do wonder if returning -EOVERFLOW may be more useful than running
the overflow_uid when mapping fails.
Also, now that I think about it. Please let's use (uid_t __user *) for
the type of argp. I think that will be more maintainable in the long
run. Easier to grep for etc.
Neither of these things are big or would prevent me from merging your
change just things that I think would be nice to have.
Eric
next prev parent reply other threads:[~2017-01-24 22:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-23 9:54 [PATCH v2 0/2] Add further ioctl() operations for namespace discovery Michael Kerrisk (man-pages)
2017-01-24 21:34 ` Michael Kerrisk (man-pages)
2017-01-24 22:41 ` Eric W. Biederman [this message]
2017-01-25 0:39 ` Michael Kerrisk (man-pages)
2017-01-25 1:03 ` [PATCH v4 " Michael Kerrisk (man-pages)
2017-01-25 1:58 ` Eric W. Biederman
2017-01-25 2:24 ` Michael Kerrisk (man-pages)
2017-01-25 2:26 ` Eric W. Biederman
2017-01-25 2:28 ` Eric W. Biederman
2017-01-25 3:50 ` Michael Kerrisk (man-pages)
2017-01-26 4:23 ` Eric W. Biederman
2017-02-03 2:34 ` Eric W. Biederman
2017-02-08 14:13 ` Michael Kerrisk (man-pages)
[not found] ` <2c27a76e-336d-e2ad-4b30-22e29249c2e9@gmail.com>
2017-01-25 1:03 ` [PATCH v4 1/2] nsfs: Add an ioctl() to return the namespace type Michael Kerrisk (man-pages)
2017-01-25 1:04 ` [PATCH v4 2/2] nsfs: Add an ioctl() to return owner UID of a userns Michael Kerrisk (man-pages)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8aggjx5.fsf@xmission.com \
--to=ebiederm@xmission.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=avagin@openvz.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=serge@hallyn.com \
--cc=viro@zeniv.linux.org.uk \
--cc=wking@tremily.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).