From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751378AbcH2H7b (ORCPT ); Mon, 29 Aug 2016 03:59:31 -0400 Received: from mga03.intel.com ([134.134.136.65]:4224 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750909AbcH2H72 (ORCPT ); Mon, 29 Aug 2016 03:59:28 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,595,1464678000"; d="asc'?scan'208";a="2172298" From: Felipe Balbi To: Tal Shorer , gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, heikki.krogerus@linux.intel.com Cc: linux-kernel@vger.kernel.org, Tal Shorer Subject: Re: [PATCH v3 0/8] usb: ulpi: remove "dev" field from struct ulpi_ops In-Reply-To: <1471363493-7836-1-git-send-email-tal.shorer@gmail.com> References: <1471363493-7836-1-git-send-email-tal.shorer@gmail.com> User-Agent: Notmuch/0.22.1+63~g994277e (https://notmuchmail.org) Emacs/25.1.1 (x86_64-pc-linux-gnu) Date: Mon, 29 Aug 2016 10:58:25 +0300 Message-ID: <87a8fwdn1a.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi folks, Tal Shorer writes: > struct ulpi_ops is defined as follows: > > struct ulpi_ops { > struct device *dev; > int (*read)(struct ulpi_ops *ops, u8 addr); > int (*write)(struct ulpi_ops *ops, u8 addr, u8 val); > }; > > Upon calling ulpi_register_interface(), the struct device argument is > put inside the struct ulpi_ops argument's dev field. Later, when > calling the actual read()/write() operations, the struct ulpi_ops is > passed to them and they use the stored device to access whatever > private data they need. > > This means that if one wishes to reuse the same oprations for multiple > interfaces (e.g if we have multiple instances of the same controller), > any but the last interface registered will not operate properly (and > the one that does work will be at the mercy of the others to not mess > it up). > > I understand that barely any driver uses this bus right now, but I > suppose it's there to be used at some point. We might as well fix the > design here before we hit this bug. > > This series fixes this by passing the given struct device directly to > the operation functions via ulpi->dev.parent in ulpi_read() and > ulpi_write(). It also changes the operations struct to be constant > since now nobody has a reason to modify it. > > Changes from v1: > * Split the actual api change into multiple patch as per Felipe Balbi's > suggestion. The series now first adds the new api, then migrates > everything to use and only then removes the old api. > > Changes from v2: > * Merge patches 2 and 3 (now patch 2) > * Merge patches 5 and 6 (now patch 4) > * Remove comment documenting the removed dev field in struct ulpi_ops > > Tal Shorer (8): > usb: ulpi: move setting of ulpi->dev parent up in ulpi_register() > usb: ulpi: add new api functions, {read|write}_dev() > usb: dwc3: ulpi: use new api > usb: ulpi: remove calls to old api callbacks > usb: ulpi: rename operations {read|write}_dev to simply {read|write} > usb: ulpi: remove "dev" field from struct ulpi_ops > usb: ulpi: make ops struct constant > usb: dwc3: ulpi: make dwc3_ulpi_ops constant I have no idea how to apply these :-) Many of the patches touch dwc3, but some touch common ulpi. Greg, is it okay if I take the entire series and send it to you during my for-next pull request? =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJXw+shAAoJEIaOsuA1yqREnEsP/jEizJwpccO1NhjclzcAgDNi kjbk8gV5rlPIWR+sE3ouOkoCb3XzQOL3cz2sXb2bsB0dsPoS2R4YYKVcBy7oxwgS 6mbEJAGZhdC5SY4E+QSKYvYVWB2l0SLgeeftpRZsMlkYN2EOM+0oCou8m6+gXPBk ooOxo8FQ6gry+ourHmgffydqS5jLcgTcmDGLKASCAVhmxSU/UUwyvf8qZkQXOEWM sncmTxDNGIwev2q0Pp3xLeUVpfaTB/oFW4iacVU7YRjwDOLDYfmmDn7AsORXfbHQ 4C7EmN1urEMUpXyzvjs2D0JmNUe99fKwSMrTjGp3lkEOcKpCogrd4F5I1UvWnlZA +W64H1gBlXi3rqj1LCFNodN9csZlrTmVzCmYljbFqxXkvJ60gXI9oMsK85eKmQ+G 9ORm44u1e739ocDLFmNjgwWdnmsAZ4iaJqdPW9XHHAMUEMEd9sLvbP3JjXREbgFL Do9zUkxkZJrt0FO76dgw5JJtWrR6zbOwgsI6VN5r5OQDwotYKYlEEn7H0pFU++C8 4d/8taz7Vnqn50VMcrQ0fmpKbFVzUa8+MpFZJozw/azXWPkNy7RzcGdXGGqGHWUl Ym1G8JxBruegE9vJgfUboPjzV17IRc77+1JtFJojgxxhDrOBwtMinrWhlPrByf7h 9Qqasw/jtz0JxpfwQFTy =aso5 -----END PGP SIGNATURE----- --=-=-=--