From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753627AbcC3N6U (ORCPT ); Wed, 30 Mar 2016 09:58:20 -0400 Received: from mga03.intel.com ([134.134.136.65]:32914 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751217AbcC3N6T (ORCPT ); Wed, 30 Mar 2016 09:58:19 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,416,1455004800"; d="asc'?scan'208";a="944488663" From: Felipe Balbi To: Arnd Bergmann Cc: Greg Kroah-Hartman , Bin Liu , Peter Chen , Kishon Vijay Abraham I , Peter Chen , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH] usb: rework CONFIG_USB_COMMON logic In-Reply-To: <4019862.J6BPYbmbYs@wuerfel> References: <1458751543-2167046-1-git-send-email-arnd@arndb.de> <871t6sqmu2.fsf@intel.com> <4019862.J6BPYbmbYs@wuerfel> User-Agent: Notmuch/0.21+96~g9bbc54b (http://notmuchmail.org) Emacs/25.0.90.3 (x86_64-pc-linux-gnu) Date: Wed, 30 Mar 2016 16:56:25 +0300 Message-ID: <87a8lghxx2.fsf@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Arnd Bergmann writes: > [ text/plain ] > On Wednesday 30 March 2016 13:31:01 Felipe Balbi wrote: >> Arnd Bergmann writes: >> > [ text/plain ] >> > The phy-am335x driver selects 'USB_COMMON', but all other drivers >> > use 'depends on' for that symbol, and it depends on USB || USB_GADGET >> > itself, which causes a Kconfig warning: >> > >> > warning: (AM335X_PHY_USB) selects USB_COMMON which has unmet direct de= pendencies (USB_SUPPORT && (USB || USB_GADGET)) >> > >> > As suggested by Felipe Balbi, this turns the logic around, and makes >> > 'USB_COMMON' selected by everything else that needs it, so we can >> > remove the dependencies. >> > >> > Fixes: 59f042f644c5 ("usb: phy: phy-am335x: bypass first VBUS sensing = for host-only mode") >> > Signed-off-by: Arnd Bergmann >> > Acked-by: Felipe Balbi >> > Reviewed-by: Peter Chen >> > --- >> > I seem to have dropped the ball on this one after my initial submission >> > when it wasn't clear who should merge the patch. >> > >> > Please apply to the USB or the USB gadget tree, whoever gets there >> > first. >>=20 >> seems like this is one of those "can wait for next merge window" right ? >> I'll take it through my tree. No issues. > > Correct, it's not urgent at all, I just want it to disappear from > my backlog of unapplied patches. https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=3Dtest= ing/next&id=3D5412212bf636f75cba8a0e3637e666b279e7067a =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJW+9sKAAoJEIaOsuA1yqREkAkP/jHZHj6Hw73acE0FF2Ds7HoC 6mzDVQ6msTzuxx6xfdAyao6rV9ptF1AYdNE/aeEPbdXfploJo0XpKBJCPXYjT5VJ Yx+5sclSlikMwTUH7VqiWL3FjTbBThIVZnacwq2dFXcqPX99Oe2IH5Bb74jov82r S7ZVJOvITXsmiUUJPPq+Gz7a91h4caS1vqgyty/3zdyIZs31FKR+tR9CwVZGixvs FkgSHBQcY9ruiV1R3KLaDoNU76tGQEtBrdOuCwi1UCabGOH3tg6d5rSjosoiw1Ph i51cGYn+pwTy3bncoqvK8/3kCDE3m95OlwG2VlZ6r+jCLfydG4Ey/d8Q1Edrx2b1 Ip9VwX0Bdz69ZXE2ljQnzyIJ8OdRTwGs+nYOZ/mb21deSMDgSl8CiQtXD+/1o2bq ThWcf7zrSdFS6uXqIDdylGm3mMcZqsOinUxCdwPNTyy/wNI1bcqfVz0xRXTqgnO7 FjF+0xCJYGuGZJ7N3NwKVHMzYFzzqAQx5Nzn+JOoGpuyFL3eBWKRaGSZ/uln5e8m MreCoOq8DU/Pp5PKAXOZn4seo8b43vC0oYOs3tMXXjTijnUOwy1FBJq/gkrkMfiN fGbVLFREYsmtBEVQ154JKwomZfiBMX/a4h8LZIPSct8/aw1QRzRRExTJgwnBVrLH +xVrphRsqCucnNsskVhH =U/Pd -----END PGP SIGNATURE----- --=-=-=--