[BUG] i915: suspend by closing Laptop lid broken

[BUG] i915: suspend by closing Laptop lid broken

[Martin Kepplinger]

So. -rc1 broke suspending by closing my laptop lid and it's not fixed in
-rc2. It works exactly *one* first time and every subsequent lid-closing
is ignored.

Biscted and tested first bad commit:
14aa02449064541217836b9f3d3295e241d5ae9c

This pulls in i915 changes as well as ACPI changes. I don't know the
driver but I'm sure you can find the mistake. I'm happy to test changes.

There are no log differences.

Re: [BUG] i915: suspend by closing Laptop lid broken

[Jani Nikula]

On Mon, 04 May 2015, Martin Kepplinger <martink@posteo.de> wrote:
> So. -rc1 broke suspending by closing my laptop lid and it's not fixed in
> -rc2. It works exactly *one* first time and every subsequent lid-closing
> is ignored.
>
> Biscted and tested first bad commit:
> 14aa02449064541217836b9f3d3295e241d5ae9c
>
> This pulls in i915 changes as well as ACPI changes. I don't know the
> driver but I'm sure you can find the mistake. I'm happy to test changes.
>
> There are no log differences.

Any chance you could bisect into the merge? It would be helpful.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center

Re: [BUG] i915: suspend by closing Laptop lid broken

[Martin Kepplinger]

Am 2015-05-04 um 13:24 schrieb Jani Nikula:
> On Mon, 04 May 2015, Martin Kepplinger <martink@posteo.de> wrote:
>> So. -rc1 broke suspending by closing my laptop lid and it's not fixed in
>> -rc2. It works exactly *one* first time and every subsequent lid-closing
>> is ignored.
>>
>> Biscted and tested first bad commit:
>> 14aa02449064541217836b9f3d3295e241d5ae9c
>>
>> This pulls in i915 changes as well as ACPI changes. I don't know the
>> driver but I'm sure you can find the mistake. I'm happy to test changes.
>>
>> There are no log differences.
> 
> Any chance you could bisect into the merge? It would be helpful.
> 
> BR,
> Jani.
> 
> 

My attempt to go into the merge was too much effort as the checkouts in
between break random other stuff.

We should be between 09d51602cf84a1264946711dd4ea0dddbac599a1 (good) and
c0f404284192f2d4a0159a714372a8c8610c1f6d. Could you have a look and
maybe you have guesses for me, what I should test? It's not sooo much
anymore, maybe you even have a guess about the bug?

thanks
                            martin

Re: [BUG] i915: suspend by closing Laptop lid broken

[Jani Nikula]

On Thu, 07 May 2015, Martin Kepplinger <martink@posteo.de> wrote:
> Am 2015-05-04 um 13:24 schrieb Jani Nikula:
>> On Mon, 04 May 2015, Martin Kepplinger <martink@posteo.de> wrote:
>>> So. -rc1 broke suspending by closing my laptop lid and it's not fixed in
>>> -rc2. It works exactly *one* first time and every subsequent lid-closing
>>> is ignored.
>>>
>>> Biscted and tested first bad commit:
>>> 14aa02449064541217836b9f3d3295e241d5ae9c
>>>
>>> This pulls in i915 changes as well as ACPI changes. I don't know the
>>> driver but I'm sure you can find the mistake. I'm happy to test changes.
>>>
>>> There are no log differences.
>> 
>> Any chance you could bisect into the merge? It would be helpful.
>> 
>> BR,
>> Jani.
>> 
>> 
>
> My attempt to go into the merge was too much effort as the checkouts in
> between break random other stuff.

This should obviously *not* be the case. :(

> We should be between 09d51602cf84a1264946711dd4ea0dddbac599a1 (good) and
> c0f404284192f2d4a0159a714372a8c8610c1f6d. Could you have a look and
> maybe you have guesses for me, what I should test? It's not sooo much
> anymore, maybe you even have a guess about the bug?

$ git log --oneline 09d51602cf..c0f4042841 | grep drm/i915 | wc -l
286

Oof, I eyeballed the list, but didn't spot any obvious candidates.

If a commit is inconclusive or borken in other ways, you could try git
bisect skip to try another commit...

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center