From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760043AbbCDIOw (ORCPT ); Wed, 4 Mar 2015 03:14:52 -0500 Received: from mga02.intel.com ([134.134.136.20]:35554 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758788AbbCDIOt convert rfc822-to-8bit (ORCPT ); Wed, 4 Mar 2015 03:14:49 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,686,1418112000"; d="scan'208";a="686625377" From: Jani Nikula To: =?utf-8?Q?Bj=C3=B8rn?= Mork Cc: Imre Deak , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Daniel Vetter , Ville =?utf-8?B?U3lyasOkbMOk?= , David Weinehall Subject: Re: [PATCH v2] drm/i915: gen4: work around hang during hibernation In-Reply-To: <87sidn8sfp.fsf@nemi.mork.no> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <1425294281-7297-1-git-send-email-imre.deak@intel.com> <87385n60re.fsf@intel.com> <87sidn8sfp.fsf@nemi.mork.no> User-Agent: Notmuch/0.19+67~g70b5ead (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Wed, 04 Mar 2015 10:15:35 +0200 Message-ID: <87a8zt41qw.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 02 Mar 2015, Bjørn Mork wrote: > Jani Nikula writes: > >> On Mon, 02 Mar 2015, Imre Deak wrote: >>> Bjørn reported that his machine hang during hibernation and eventually >>> bisected the problem to the following commit: >>> >>> commit da2bc1b9db3351addd293e5b82757efe1f77ed1d >>> Author: Imre Deak >>> Date: Thu Oct 23 19:23:26 2014 +0300 >>> >>> drm/i915: add poweroff_late handler >>> >>> The problem seems to be that after the kernel puts the device into D3 >>> the BIOS still tries to access it, or otherwise assumes that it's in D0. >>> This is clearly bogus, since ACPI mandates that devices are put into D3 >>> by the OSPM if they are not wake-up sources. In the future we want to >>> unify more of the driver's runtime and system suspend paths, for example >>> by skipping all the system suspend/hibernation hooks if the device is >>> runtime suspended already. Accordingly for all other platforms the goal >>> is still to properly power down the device during hibernation. >>> >>> v2: >>> - Another GEN4 Lenovo laptop had the same issue, while platforms from >>> other vendors (including mobile and desktop, GEN4 and non-GEN4) seem >>> to work fine. Based on this apply the workaround on all GEN4 Lenovo >>> platforms. >>> - add code comment about failing platforms (Ville) >>> >>> Reference: http://lists.freedesktop.org/archives/intel-gfx/2015-February/060633.html >>> Reported-and-bisected-by: Bjørn Mork >>> Signed-off-by: Imre Deak >> >> Bjørn, I would really appreciate your Tested-by on this patch before I >> queue it for v4.0 and cc: stable for v3.19. > > No problem. This version still works fine for me. Feel free to add > > Tested-by: Bjørn Mork Pushed to drm-intel-fixes with Daniel's IRC ack. Thanks for the patch and testing. BR, Jani. > > > > Bjørn -- Jani Nikula, Intel Open Source Technology Center