From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>,
Don Mullis <don.mullis@gmail.com>,
Dave Chinner <david@fromorbit.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/4] lib: list_sort: Various minor improvements
Date: Thu, 26 Jun 2014 00:47:12 +0200 [thread overview]
Message-ID: <87a990obdb.fsf@rasmusvillemoes.dk> (raw)
In-Reply-To: <20140625153246.3d3dbda781ce1af5524269ab@linux-foundation.org> (Andrew Morton's message of "Wed, 25 Jun 2014 15:32:46 -0700")
Andrew Morton <akpm@linux-foundation.org> writes:
> On Thu, 26 Jun 2014 00:28:18 +0200 Rasmus Villemoes <linux@rasmusvillemoes.dk> wrote:
>
>> Minor comment: Won't this end up saying "list_sort_test: list passed to
>> ...", despite the list coming from a 'real' user? Maybe change the first
>> #define to '"list_sort: " fmt', the above message to "passed list too
>> long for efficiency", and redefine pr_fmt right after #ifdef
>> CONFIG_TEST_LIST_SORT.
>
> Yeah, I was hoping nobody would notice that ;)
>
> How about just
>
> printk_once(KERN_DEBUG "list too long for efficiency\n");
FWIW, fine by me.
Rasmus
prev parent reply other threads:[~2014-06-25 22:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-24 10:06 [PATCH v2 0/4] lib: list_sort: Various minor improvements Rasmus Villemoes
2014-06-24 10:06 ` [PATCH v2 1/4] lib: list_sort_test(): Return -ENOMEM when allocation fails Rasmus Villemoes
2014-06-24 10:06 ` [PATCH v2 2/4] lib: list_sort_test(): Add extra corruption check Rasmus Villemoes
2014-06-24 10:06 ` [PATCH v2 3/4] lib: list_sort_test(): Simplify and harden cleanup Rasmus Villemoes
2014-06-24 10:06 ` [PATCH v2 4/4] lib: list_sort.c: Limit number of unused cmp callbacks Rasmus Villemoes
2014-06-25 21:53 ` [PATCH v2 0/4] lib: list_sort: Various minor improvements Andrew Morton
2014-06-25 22:28 ` Rasmus Villemoes
2014-06-25 22:32 ` Andrew Morton
2014-06-25 22:47 ` Rasmus Villemoes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a990obdb.fsf@rasmusvillemoes.dk \
--to=linux@rasmusvillemoes.dk \
--cc=akpm@linux-foundation.org \
--cc=artem.bityutskiy@linux.intel.com \
--cc=david@fromorbit.com \
--cc=don.mullis@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox