* [PATCH] export: declare ksymtab symbols
@ 2013-12-17 9:38 Johannes Berg
2013-12-17 16:32 ` Andi Kleen
0 siblings, 1 reply; 3+ messages in thread
From: Johannes Berg @ 2013-12-17 9:38 UTC (permalink / raw)
To: Rusty Russell; +Cc: Andi Kleen, linux-kernel, Johannes Berg
From: Johannes Berg <johannes.berg@intel.com>
sparse complains about any __ksymtab symbols with the following:
warning: symbol '__ksymtab_...' was not declared. Should it be static?
due to Andi's patch making it non-static.
Mollify sparse by declaring the symbol extern, otherwise we get
drowned in sparse warnings for anything that uses EXPORT_SYMBOL
in the sources, making it easy to miss real warnings.
Cc: Andi Kleen <ak@linux.intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
include/linux/export.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/export.h b/include/linux/export.h
index 3f2793d..96e45ea 100644
--- a/include/linux/export.h
+++ b/include/linux/export.h
@@ -59,6 +59,7 @@ extern struct module __this_module;
static const char __kstrtab_##sym[] \
__attribute__((section("__ksymtab_strings"), aligned(1))) \
= VMLINUX_SYMBOL_STR(sym); \
+ extern const struct kernel_symbol __ksymtab_##sym; \
__visible const struct kernel_symbol __ksymtab_##sym \
__used \
__attribute__((section("___ksymtab" sec "+" #sym), unused)) \
--
1.8.5.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] export: declare ksymtab symbols
2013-12-17 9:38 [PATCH] export: declare ksymtab symbols Johannes Berg
@ 2013-12-17 16:32 ` Andi Kleen
2014-01-14 23:46 ` Rusty Russell
0 siblings, 1 reply; 3+ messages in thread
From: Andi Kleen @ 2013-12-17 16:32 UTC (permalink / raw)
To: Johannes Berg; +Cc: Rusty Russell, linux-kernel, Johannes Berg
> Cc: Andi Kleen <ak@linux.intel.com>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Acked-by: Andi Kleen <ak@linux.intel.com>
-Andi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] export: declare ksymtab symbols
2013-12-17 16:32 ` Andi Kleen
@ 2014-01-14 23:46 ` Rusty Russell
0 siblings, 0 replies; 3+ messages in thread
From: Rusty Russell @ 2014-01-14 23:46 UTC (permalink / raw)
To: Andi Kleen, Johannes Berg; +Cc: linux-kernel, Johannes Berg
Andi Kleen <ak@linux.intel.com> writes:
>> Cc: Andi Kleen <ak@linux.intel.com>
>> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
>
> Acked-by: Andi Kleen <ak@linux.intel.com>
Thanks, applied.
I added:
Fixes: e0f244c63fc9 ("asmlinkage, module: Make ksymtab [...] __visible")
Cheers,
Rusty.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-15 2:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-17 9:38 [PATCH] export: declare ksymtab symbols Johannes Berg
2013-12-17 16:32 ` Andi Kleen
2014-01-14 23:46 ` Rusty Russell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox