[PATCH] export: declare ksymtab symbols

[PATCH] export: declare ksymtab symbols

[Johannes Berg]

From: Johannes Berg <johannes.berg@intel.com>

sparse complains about any __ksymtab symbols with the following:

 warning: symbol '__ksymtab_...' was not declared. Should it be static?

due to Andi's patch making it non-static.

Mollify sparse by declaring the symbol extern, otherwise we get
drowned in sparse warnings for anything that uses EXPORT_SYMBOL
in the sources, making it easy to miss real warnings.

Cc: Andi Kleen <ak@linux.intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
 include/linux/export.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/export.h b/include/linux/export.h
index 3f2793d..96e45ea 100644
--- a/include/linux/export.h
+++ b/include/linux/export.h
@@ -59,6 +59,7 @@ extern struct module __this_module;
 	static const char __kstrtab_##sym[]			\
 	__attribute__((section("__ksymtab_strings"), aligned(1))) \
 	= VMLINUX_SYMBOL_STR(sym);				\
+	extern const struct kernel_symbol __ksymtab_##sym;	\
 	__visible const struct kernel_symbol __ksymtab_##sym	\
 	__used							\
 	__attribute__((section("___ksymtab" sec "+" #sym), unused))	\
-- 
1.8.5.1

Re: [PATCH] export: declare ksymtab symbols

[Andi Kleen]

> Cc: Andi Kleen <ak@linux.intel.com>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>

Acked-by: Andi Kleen <ak@linux.intel.com>

-Andi

Re: [PATCH] export: declare ksymtab symbols

[Rusty Russell]

Andi Kleen <ak@linux.intel.com> writes:
>> Cc: Andi Kleen <ak@linux.intel.com>
>> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
>
> Acked-by: Andi Kleen <ak@linux.intel.com>

Thanks, applied.

I added:

Fixes: e0f244c63fc9 ("asmlinkage, module: Make ksymtab [...] __visible")

Cheers,
Rusty.