public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Roberto Vitillo <ravitillo@lbl.gov>
Cc: linux-kernel@vger.kernel.org, a.p.zijlstra@chello.nl,
	paulus@samba.org, mingo@redhat.com, acme@ghostprotocols.net
Subject: Re: [PATCH v2] perf: add callgrind conversion tool
Date: Wed, 27 Mar 2013 16:23:27 +0900	[thread overview]
Message-ID: <87a9ppgvbk.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <CA+BNSkWCX2TVYU26A7qHFqr6F5Pw44wy76BSfnS5MnVDKGCh9w@mail.gmail.com> (Roberto Vitillo's message of "Tue, 26 Mar 2013 12:14:49 -0700")

Hi Roberto,

On Tue, 26 Mar 2013 12:14:49 -0700, Roberto Vitillo wrote:
> The proposed patch adds the convert tool to perf which allows to convert a
> perf.data file to a set of callgrind data files which can subsequently be
> displayed with kcachegrind.
>
> Note that the code may trigger the following bug in libbfd:
> http://sourceware.org/bugzilla/show_bug.cgi?id=15106

Does it now support call graph too?  Great if so!

Anyway, I suggest that splitting patch to two - one for addr2line and
another for actual 'convert' tool.  I think we *can* use the tool
without libbfd (but with external addr2line binary or even with no line
number information).

And it seems there's some linewraps.

Thanks,
Namhyung

  reply	other threads:[~2013-03-27  7:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-26 19:14 [PATCH v2] perf: add callgrind conversion tool Roberto Vitillo
2013-03-27  7:23 ` Namhyung Kim [this message]
2013-03-27 17:07   ` Roberto Vitillo
2013-03-27 14:26 ` Peter Zijlstra
2013-03-27 21:26 ` Viktor Ostashevskyi
2013-03-28 23:58 ` Sukadev Bhattiprolu
2013-03-29  4:18   ` Namhyung Kim
2013-03-29  4:50     ` Roberto Vitillo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a9ppgvbk.fsf@sejong.aot.lge.com \
    --to=namhyung@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=paulus@samba.org \
    --cc=ravitillo@lbl.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox