From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753314Ab3A3E4l (ORCPT ); Tue, 29 Jan 2013 23:56:41 -0500 Received: from LGEMRELSE7Q.lge.com ([156.147.1.151]:52675 "EHLO LGEMRELSE7Q.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752281Ab3A3E4h (ORCPT ); Tue, 29 Jan 2013 23:56:37 -0500 X-AuditID: 9c930197-b7ca4ae000006ba8-27-5108a802cd07 From: Namhyung Kim To: Borislav Petkov Cc: Thomas Backlund , Linux Kernel Mailing List , Arnaldo Carvalho de Melo , Jiri Olsa Subject: Re: perf 3.8-rc build failure: undefined reference to `strlcpy' References: <51074E9D.3040803@mageia.org> <20130129103722.GE14444@pd.tnic> <87ehh3v2jo.fsf@sejong.aot.lge.com> <20130130032831.GA30965@pd.tnic> Date: Wed, 30 Jan 2013 13:56:34 +0900 In-Reply-To: <20130130032831.GA30965@pd.tnic> (Borislav Petkov's message of "Wed, 30 Jan 2013 04:28:31 +0100") Message-ID: <87a9rruv3x.fsf@sejong.aot.lge.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Brightmail-Tracker: AAAAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 30 Jan 2013 04:28:31 +0100, Borislav Petkov wrote: > On Wed, Jan 30, 2013 at 11:15:55AM +0900, Namhyung Kim wrote: >> Please see my reply on another post from Thomas: >> >> https://lkml.org/lkml/2013/1/29/32 >> >> It's not like a build failure of perf tools, it's just a result of >> feature test so should not affect the build of perf itself, right? > > Doh, I see it. It is the -DHAVE_STRLCPY test, of course. And it happens > only with a V=1 build, so actually there's not a build problem. > >> Why it confuses us is that we don't show any compile message if -s >> option is given to make, so I posted a patch to hide CHK and above >> failure message when -s option is specified. > > Hm, trying your patch ontop of acme's perf/core still shows CHK stuff > > $ make -s tools/perf > DESCEND perf > CHK -fstack-protector-all > CHK -Wstack-protector > CHK -Wvolatile-register-var > CHK bionic > CHK libelf > CHK libdw > ... > > > and that's because I'm doing the build from the toplevel repo and not in > perf/. If I switch to perf first, it is silent: > > $ make -s > Makefile:809: No bfd.h/libbfd found, install binutils-dev[el]/zlib-static to gain symbol demangling > Makefile:846: No numa.h found, disables 'perf bench numa mem' benchmark, please install numa-libs-devel or libnuma-dev > $ That's because the toplevel Makefile resets MAKEFLAGS in the middle: Makefile:1330 # Clear a bunch of variables before executing the submake tools/: FORCE $(Q)mkdir -p $(objtree)/tools $(Q)$(MAKE) LDFLAGS= MAKEFLAGS= O=$(objtree) subdir=tools -C $(src)/tools/ tools/%: FORCE $(Q)mkdir -p $(objtree)/tools $(Q)$(MAKE) LDFLAGS= MAKEFLAGS= O=$(objtree) subdir=tools -C $(src)/tools/ $* So why should it be reset in the first place? > > Oh, and one more thing, there's tools/scripts/Makefile.include which > looks at -s already and perf/Makefile includes it so you probably want > to put your change there so that all tools use it. Are you suggesting that moving "try-cc" to the Makefile.include? Thanks, Namhyung