From: ebiederm@xmission.com (Eric W. Biederman)
To: Stanislav Kinsbursky <skinsbursky@parallels.com>
Cc: akpm@linux-foundation.org, catalin.marinas@arm.com,
will.deacon@arm.com, dhowells@redhat.com,
manfred@colorfullife.com, hughd@google.com, jmorris@namei.org,
mtk.manpages@gmail.com, kosaki.motohiro@jp.fujitsu.com,
paulmck@linux.vnet.ibm.com, sds@tycho.nsa.gov, devel@openvz.org,
a.p.zijlstra@chello.nl, cmetcalf@tilera.com,
linux-driver@qlogic.com, ron.mercer@qlogic.com,
viro@zeniv.linux.org.uk, eparis@parisplace.org,
tglx@linutronix.de, jitendra.kalsaria@qlogic.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org, casey@schaufler-ca.com,
"Michael Kerrisk \(man-pages\)" <mtk.manpages@gmail.com>
Subject: Re: [PATCH v7 00/10] IPC: checkpoint/restore in userspace enhancements
Date: Thu, 18 Oct 2012 05:11:08 -0700 [thread overview]
Message-ID: <87a9vk3rqb.fsf@xmission.com> (raw)
In-Reply-To: <20121018101543.16036.12221.stgit@localhost.localdomain> (Stanislav Kinsbursky's message of "Thu, 18 Oct 2012 14:22:21 +0400")
Nacked-by: "Eric W. Biederman" <ebiederm@xmission.com>
You ignored all of my feedback that the first 7 messages of your
patchset are unnecessary. In particular you did not attempt to focus
your patchset on those operations that are most important.
Upon examination it appears also that the 8th and 9th patches of the
patchset are also unnecessary. And the 10th patch is just a test of the
previous patches, making the 10th patch unneceesary without the rest.
In net this entire patchset is unnecessary and a waste of your reviewers
time.
Once you have IPC checkpoint and restore working there may be a point to
come back and optimize things. Please don't come back with any System V
Interprocess Communication patches until you can report how much time
is saved by each and every change.
Eric
prev parent reply other threads:[~2012-10-18 12:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 10:22 [PATCH v7 00/10] IPC: checkpoint/restore in userspace enhancements Stanislav Kinsbursky
2012-10-18 10:22 ` [PATCH v7 01/10] ipc: remove forced assignment of selected message Stanislav Kinsbursky
2012-10-18 10:22 ` [PATCH v7 02/10] ipc: "use key as id" functionality for resource get system call introduced Stanislav Kinsbursky
2012-10-18 10:22 ` [PATCH v7 03/10] ipc: segment key change helper introduced Stanislav Kinsbursky
2012-10-18 10:22 ` [PATCH v7 04/10] ipc: add new SHM_SET command for sys_shmctl() call Stanislav Kinsbursky
2012-10-18 10:23 ` [PATCH v7 05/10] ipc: add new MSG_SET command for sys_msgctl() call Stanislav Kinsbursky
2012-10-18 10:23 ` [PATCH v7 06/10] qlge driver: rename internal SEM_SET macro to SEM_INIT Stanislav Kinsbursky
2012-10-18 10:23 ` [PATCH v7 07/10] ipc: add new SEM_SET command for sys_semctl() call Stanislav Kinsbursky
2012-10-18 10:23 ` [PATCH v7 08/10] IPC: message queue receive cleanup Stanislav Kinsbursky
2012-10-18 10:23 ` [PATCH v7 09/10] IPC: message queue copy feature introduced Stanislav Kinsbursky
2012-10-18 10:39 ` Michael Kerrisk (man-pages)
2012-10-18 10:23 ` [PATCH v7 10/10] test: IPC message queue copy feture test Stanislav Kinsbursky
2012-10-18 10:41 ` [PATCH v7 00/10] IPC: checkpoint/restore in userspace enhancements Michael Kerrisk (man-pages)
2012-10-18 12:11 ` Eric W. Biederman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a9vk3rqb.fsf@xmission.com \
--to=ebiederm@xmission.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=casey@schaufler-ca.com \
--cc=catalin.marinas@arm.com \
--cc=cmetcalf@tilera.com \
--cc=devel@openvz.org \
--cc=dhowells@redhat.com \
--cc=eparis@parisplace.org \
--cc=hughd@google.com \
--cc=jitendra.kalsaria@qlogic.com \
--cc=jmorris@namei.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-driver@qlogic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=mtk.manpages@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=ron.mercer@qlogic.com \
--cc=sds@tycho.nsa.gov \
--cc=skinsbursky@parallels.com \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox