From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754234Ab2IXGgb (ORCPT ); Mon, 24 Sep 2012 02:36:31 -0400 Received: from mail.parknet.co.jp ([210.171.160.6]:42270 "EHLO mail.parknet.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753606Ab2IXGga (ORCPT ); Mon, 24 Sep 2012 02:36:30 -0400 From: OGAWA Hirofumi To: Namjae Jeon Cc: akpm@linux-foundation.org, bfields@fieldses.org, viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org, Namjae Jeon , Ravishankar N , Amit Sahrawat Subject: Re: [PATCH v3 2/5] fat: allocate persistent inode numbers References: <1347798148-2660-1-git-send-email-linkinjeon@gmail.com> <87lig28fak.fsf@devron.myhome.or.jp> <87ipb45914.fsf@devron.myhome.or.jp> <87ehls53ug.fsf@devron.myhome.or.jp> Date: Mon, 24 Sep 2012 15:36:27 +0900 In-Reply-To: <87ehls53ug.fsf@devron.myhome.or.jp> (OGAWA Hirofumi's message of "Mon, 24 Sep 2012 15:31:35 +0900") Message-ID: <87a9wg53mc.fsf@devron.myhome.or.jp> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org OGAWA Hirofumi writes: > Namjae Jeon writes: > >>> What is problem if i_ino + i_generation is not match? I think, even if >>> those didn't match, i_pos in FH should resolve issue, no? >> No, It can not resolve issue. >> in NFS file handle, there is a reference to the current inode number. >> So, if by eviction that is changed - that it will results in "file id >> changed" error. > > Who returns error? This means - which code returns error? >> even though using the i_pos we can reconstruct and get the INODE on >> the Server, but the NFS handle is no more valid. As the inode number >> is also changed, iunique() for the file will result in different >> number this time. -- OGAWA Hirofumi