From: Kevin Hilman <khilman@ti.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Tarun Kanti DebBarma <tarun.kanti@ti.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Rajendra Nayak <rnayak@ti.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>, "Cousson\,
Benoit" <b-cousson@ti.com>, Paul Walmsley <paul@pwsan.com>
Subject: Re: [PATCH 2/2] gpio/omap: add *remove* callback in platform_driver
Date: Thu, 12 Jul 2012 10:48:01 -0700 [thread overview]
Message-ID: <87a9z4g9bi.fsf@ti.com> (raw)
In-Reply-To: <CACRpkdZMG_ZHW_eGGrdrJh1SuO_=hOObijzmxG1ob6RoNf_dwg@mail.gmail.com> (Linus Walleij's message of "Thu, 12 Jul 2012 13:03:00 +0200")
Hi Linus,
Linus Walleij <linus.walleij@linaro.org> writes:
> On Thu, Jul 12, 2012 at 1:25 AM, Kevin Hilman <khilman@ti.com> wrote:
>
>> There is quite a bit of other things to do in remove to properly cleanup
>> what is done in probe.
>
> OK I'm dropping this patch for now...
>
Thanks.
For future reference... as one of the OMAP maintainers, I request that
you not pull/merge OMAP GPIO patches unless they've had a bit of review
and exposure. Unfortunately, we have a history with this driver where
regressions have been introduced and the maintainers end up having to
find and fix them.
In the case of OMAP GPIO, unless it's an obvious fix, I would recommend
you wait at least until you see some acks/tested tags from any of
- Santosh Shilimkar <santosh.shilimkar@ti.com>
- Rajendra Nayak <rnayak@ti.com>
- Benoit Cousson <b-cousson@ti.com>
or Tony, Paul or myself.
For major series, I have been collecting/queueing them for Grant after
ensuring they have been well reviewed and well tested (although I am
eagerly hoping to hand off this role to someone else.)
Thanks,
Kevin
next prev parent reply other threads:[~2012-07-12 17:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-11 9:13 [PATCH 0/2] gpio/omap: few code realignment and update of missing code Tarun Kanti DebBarma
2012-07-11 9:13 ` [PATCH 1/2] gpio/omap: move bank->dbck initialization to omap_gpio_mod_init() Tarun Kanti DebBarma
2012-07-11 17:51 ` Paul Walmsley
2012-07-11 17:56 ` DebBarma, Tarun Kanti
2012-07-11 21:51 ` Linus Walleij
2012-07-11 9:13 ` [PATCH 2/2] gpio/omap: add *remove* callback in platform_driver Tarun Kanti DebBarma
2012-07-11 21:54 ` Linus Walleij
2012-07-11 23:25 ` Kevin Hilman
2012-07-12 11:03 ` Linus Walleij
2012-07-12 17:48 ` Kevin Hilman [this message]
2012-07-14 20:51 ` Linus Walleij
2012-07-16 17:10 ` Kevin Hilman
2012-07-16 20:49 ` Linus Walleij
2012-07-16 22:01 ` Kevin Hilman
2012-07-17 6:03 ` Shilimkar, Santosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a9z4g9bi.fsf@ti.com \
--to=khilman@ti.com \
--cc=b-cousson@ti.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=rnayak@ti.com \
--cc=santosh.shilimkar@ti.com \
--cc=tarun.kanti@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox