* [2.6.38-rc8, patch] minor ANSI prototype sparse fix
@ 2011-03-08 14:01 Daniel J Blueman
2011-03-10 23:15 ` Rusty Russell
0 siblings, 1 reply; 2+ messages in thread
From: Daniel J Blueman @ 2011-03-08 14:01 UTC (permalink / raw)
To: Rusty Russell; +Cc: Linux Kernel
Fix function prototype to be ANSI-C compliant, consistent with other
function prototypes, addressing a sparse warning.
Signed-off-by: Daniel J Blueman <daniel.blueman@gmail.com>
diff --git a/kernel/module.c b/kernel/module.c
index efa290e..be35185 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -1627,7 +1627,7 @@ void unset_section_ro_nx(struct module *mod,
void *module_region)
}
/* Iterate through all modules and set each module's text as RW */
-void set_all_modules_text_rw()
+void set_all_modules_text_rw(void)
{
struct module *mod;
@@ -1648,7 +1648,7 @@ void set_all_modules_text_rw()
}
/* Iterate through all modules and set each module's text as RO */
-void set_all_modules_text_ro()
+void set_all_modules_text_ro(void)
{
struct module *mod;
--
Daniel J Blueman
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [2.6.38-rc8, patch] minor ANSI prototype sparse fix
2011-03-08 14:01 [2.6.38-rc8, patch] minor ANSI prototype sparse fix Daniel J Blueman
@ 2011-03-10 23:15 ` Rusty Russell
0 siblings, 0 replies; 2+ messages in thread
From: Rusty Russell @ 2011-03-10 23:15 UTC (permalink / raw)
To: Daniel J Blueman; +Cc: Linux Kernel
On Tue, 8 Mar 2011 22:01:47 +0800, Daniel J Blueman <daniel.blueman@gmail.com> wrote:
> Fix function prototype to be ANSI-C compliant, consistent with other
> function prototypes, addressing a sparse warning.
>
> Signed-off-by: Daniel J Blueman <daniel.blueman@gmail.com>
Thanks, applied.
FYI: your patch was line-wrapped, fixed manually:
> diff --git a/kernel/module.c b/kernel/module.c
> index efa290e..be35185 100644
> --- a/kernel/module.c
> +++ b/kernel/module.c
> @@ -1627,7 +1627,7 @@ void unset_section_ro_nx(struct module *mod,
> void *module_region)
> }
>
Cheers,
Rusty.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-11 3:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-08 14:01 [2.6.38-rc8, patch] minor ANSI prototype sparse fix Daniel J Blueman
2011-03-10 23:15 ` Rusty Russell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox