Re: [patch 1/1] leds: add keyboard num/caps lock trigger

[Arnaud Patard (Rtp) <arnaud.patard@rtp-net.org>]

Samuel Thibault <samuel.thibault@ens-lyon.org> writes:

> Hello,

Hi,
>
>
> Arnaud Patard, le Thu 13 Jan 2011 13:59:13 +0100, a écrit :
>> Implement a led trigger which enable/disable a led according
>> to keyboard leds events.
>
> This is already being implemented in a more generic and useful way,
> also permitting to use the keyboard leds for other triggers, see the
> leds-route-kbd-leds-through-the-generic-leds-layer.patch in the mm tree,
> and the “route kbd LEDs through the generic LEDs layer” thread here.

I've download the patch at [1] and after a quick runtime test, got no
success. When booting with the LEDS_INPUT set to y, the machine is
hanging. I didn't have a serial console at hand so no log for now. I've
then tried it as module, and it didn't work too. No freeze, but led
state did not change.
Moreover, I found a bug. The kbd_update_leds_helper() change is
wrong. It should use !!(leds & (1<<VC_*)) and not !!(leds & VC_*).

btw, my use case/problem is different than yours. I've a arm system
where the keyboard is usb hid one and the led I'm trying to control a
led connected on a gpio.

Arnaud

[1] http://userweb.kernel.org/~akpm/mmotm/broken-out/leds-route-kbd-leds-through-the-generic-leds-layer.patch