* [PATCH] Gpu: drm: fix buffer overflow in nouveau_bios.c
@ 2010-02-20 18:49 chris.nicholson
2010-02-20 19:58 ` Francisco Jerez
0 siblings, 1 reply; 2+ messages in thread
From: chris.nicholson @ 2010-02-20 18:49 UTC (permalink / raw)
To: airlied, bskeggs, madman2003, koriakin, currojerez, tacconet
Cc: dri-devel, linux-kernel
From: Chris Nicholson <chris@port.cnick.org.uk>
This is a patch to the nouveau_bios.c file that fixes up a
buffer overflow
Signed-off-by: Chris Nicholson <chris.nicholson@cnick.org.uk>
---
drivers/gpu/drm/nouveau/nouveau_bios.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c b/drivers/gpu/drm/nouveau/nouveau_bios.c
index 0e9cd1d..c1cee91 100644
--- a/drivers/gpu/drm/nouveau/nouveau_bios.c
+++ b/drivers/gpu/drm/nouveau/nouveau_bios.c
@@ -762,7 +762,7 @@ static uint32_t get_tmds_index_reg(struct drm_device *dev, uint8_t mlv)
dacoffset ^= 8;
return 0x6808b0 + dacoffset;
} else {
- if (mlv > ARRAY_SIZE(pramdac_table)) {
+ if (mlv >= ARRAY_SIZE(pramdac_table)) {
NV_ERROR(dev, "Magic Lookup Value too big (%02X)\n",
mlv);
return 0;
--
1.6.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Gpu: drm: fix buffer overflow in nouveau_bios.c
2010-02-20 18:49 [PATCH] Gpu: drm: fix buffer overflow in nouveau_bios.c chris.nicholson
@ 2010-02-20 19:58 ` Francisco Jerez
0 siblings, 0 replies; 2+ messages in thread
From: Francisco Jerez @ 2010-02-20 19:58 UTC (permalink / raw)
To: chris.nicholson
Cc: airlied, bskeggs, madman2003, koriakin, tacconet, dri-devel,
linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1018 bytes --]
chris.nicholson@cnick.org.uk writes:
> From: Chris Nicholson <chris@port.cnick.org.uk>
>
> This is a patch to the nouveau_bios.c file that fixes up a
> buffer overflow
>
This bug was already fixed upstream (774baeb0ba92bcb082f9868726a27a015c9a0897).
In any case, thank you.
> Signed-off-by: Chris Nicholson <chris.nicholson@cnick.org.uk>
> ---
> drivers/gpu/drm/nouveau/nouveau_bios.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c b/drivers/gpu/drm/nouveau/nouveau_bios.c
> index 0e9cd1d..c1cee91 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_bios.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_bios.c
> @@ -762,7 +762,7 @@ static uint32_t get_tmds_index_reg(struct drm_device *dev, uint8_t mlv)
> dacoffset ^= 8;
> return 0x6808b0 + dacoffset;
> } else {
> - if (mlv > ARRAY_SIZE(pramdac_table)) {
> + if (mlv >= ARRAY_SIZE(pramdac_table)) {
> NV_ERROR(dev, "Magic Lookup Value too big (%02X)\n",
> mlv);
> return 0;
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-02-20 19:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-20 18:49 [PATCH] Gpu: drm: fix buffer overflow in nouveau_bios.c chris.nicholson
2010-02-20 19:58 ` Francisco Jerez
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox