From: Andi Kleen <andi@firstfloor.org>
To: Shaohua Li <shaohua.li@intel.com>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
Jesper Juhl <jesper.juhl@gmail.com>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH] PCI Express ASPM support should default to 'No'
Date: Thu, 24 Apr 2008 09:49:47 +0200 [thread overview]
Message-ID: <87abjjzo84.fsf@basil.nowhere.org> (raw)
In-Reply-To: <1208912721.31625.3.camel@sli10-desk.sh.intel.com> (Shaohua Li's message of "Wed, 23 Apr 2008 09:05:21 +0800")
Shaohua Li <shaohua.li@intel.com> writes:
> On Tue, 2008-04-22 at 17:12 -0700, Jesse Barnes wrote:
>> On Tuesday, April 22, 2008 3:28 pm Jesper Juhl wrote:
>> > Running 'make oldconfig' I just noticed that PCIEASPM defaults to
>> > 'y' in Kconfig even though the feature is both experimental and the
>> > help text recommends that if you are unsure you say 'n'.
>> > It seems to me that this really should default to 'n', not 'y' at the
>> > moment.
>> > The following patch makes that change. Please consider applying.
>>
>> Seem reasonable, Shaohua? Please cc linux-pci on PCI patches
>> though...
> Ok, I'm fine with the patch. Though by default, the policy is to use
> BIOS setting, that is if BIOS disables ASPM, we don't enable it too.
Once the feature is considered stable it would be nice to make it default y
again. I think any power saving should be on by default (unless serious
issues are known), not off.
-Andi
next prev parent reply other threads:[~2008-04-24 7:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-22 22:28 [PATCH] PCI Express ASPM support should default to 'No' Jesper Juhl
2008-04-23 0:12 ` Jesse Barnes
2008-04-23 1:05 ` Shaohua Li
2008-04-23 22:46 ` Jesse Barnes
2008-04-24 7:49 ` Andi Kleen [this message]
2008-04-24 8:02 ` Shaohua Li
2008-04-24 15:33 ` Jesse Barnes
2008-04-25 1:16 ` Shaohua Li
2008-04-27 20:01 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87abjjzo84.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=jbarnes@virtuousgeek.org \
--cc=jesper.juhl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox