[PATCH] ALSA: pcm: Drop the space after ! operator

[PATCH] ALSA: pcm: Drop the space after ! operator

[Claudiu]

From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>

Drop the space after ! operator to follow the coding style.

Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
---
 sound/core/pcm_native.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c
index 674b50c7c5f6..65822e53924c 100644
--- a/sound/core/pcm_native.c
+++ b/sound/core/pcm_native.c
@@ -246,7 +246,7 @@ int snd_pcm_info_user(struct snd_pcm_substream *substream,
 	struct snd_pcm_info *info __free(kfree) =
 		kmalloc_obj(*info);
 
-	if (! info)
+	if (!info)
 		return -ENOMEM;
 	err = snd_pcm_info(substream, info);
 	if (err >= 0) {
@@ -607,7 +607,7 @@ static int period_to_usecs(struct snd_pcm_runtime *runtime)
 {
 	int usecs;
 
-	if (! runtime->rate)
+	if (!runtime->rate)
 		return -1; /* invalid */
 
 	/* take 75% of period time as the deadline */
@@ -1735,7 +1735,7 @@ static int snd_pcm_do_suspend(struct snd_pcm_substream *substream,
 	struct snd_pcm_runtime *runtime = substream->runtime;
 	if (runtime->trigger_master != substream)
 		return 0;
-	if (! snd_pcm_running(substream))
+	if (!snd_pcm_running(substream))
 		return 0;
 	substream->ops->trigger(substream, SNDRV_PCM_TRIGGER_SUSPEND);
 	runtime->stop_operating = true;
@@ -1789,7 +1789,7 @@ int snd_pcm_suspend_all(struct snd_pcm *pcm)
 	struct snd_pcm_substream *substream;
 	int stream, err = 0;
 
-	if (! pcm)
+	if (!pcm)
 		return 0;
 
 	for_each_pcm_substream(pcm, stream, substream) {
@@ -2066,7 +2066,7 @@ static int snd_pcm_do_drain_init(struct snd_pcm_substream *substream,
 		switch (runtime->state) {
 		case SNDRV_PCM_STATE_PREPARED:
 			/* start playback stream if possible */
-			if (! snd_pcm_playback_empty(substream)) {
+			if (!snd_pcm_playback_empty(substream)) {
 				snd_pcm_do_start(substream, SNDRV_PCM_STATE_DRAINING);
 				snd_pcm_post_start(substream, SNDRV_PCM_STATE_DRAINING);
 			} else {
@@ -3212,7 +3212,7 @@ static snd_pcm_uframes_t recalculate_boundary(struct snd_pcm_runtime *runtime)
 	snd_pcm_uframes_t border;
 	int order;
 
-	if (! runtime->buffer_size)
+	if (!runtime->buffer_size)
 		return 0;
 
 	border = 0x7fffffffUL - runtime->buffer_size;
@@ -3253,7 +3253,7 @@ static int snd_pcm_ioctl_sync_ptr_compat(struct snd_pcm_substream *substream,
 	status = runtime->status;
 	control = runtime->control;
 	boundary = recalculate_boundary(runtime);
-	if (! boundary)
+	if (!boundary)
 		boundary = 0x7fffffff;
 	scoped_guard(pcm_stream_lock_irq, substream) {
 		/* FIXME: we should consider the boundary for the sync from app */
-- 
2.43.0

Re: [PATCH] ALSA: pcm: Drop the space after ! operator

[Takashi Iwai]

On Fri, 03 Apr 2026 15:23:01 +0200,
Claudiu wrote:
> 
> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> 
> Drop the space after ! operator to follow the coding style.
> 
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>

In general we don't apply a patch only fixing the white-space or
trivial coding style issues alone, especially for the files that
aren't really much modified.

If you have a cleanup as a prerequisite for the further changes, I'll
happily pick up together, though.


thanks,

Takashi

Re: [PATCH] ALSA: pcm: Drop the space after ! operator

[Claudiu Beznea]

On 4/7/26 16:35, Takashi Iwai wrote:
> On Fri, 03 Apr 2026 15:23:01 +0200,
> Claudiu wrote:
>>
>> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>>
>> Drop the space after ! operator to follow the coding style.
>>
>> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> 
> In general we don't apply a patch only fixing the white-space or
> trivial coding style issues alone, especially for the files that
> aren't really much modified.

OK

> 
> If you have a cleanup as a prerequisite for the further changes, I'll
> happily pick up together, though.

Nothing more than this. I just went though this code while working on [1] and 
noticed the coding style inconsistency here, thus this patch.

Thank you,
Claudiu

[1] 
https://lore.kernel.org/all/20260407133507.887404-1-claudiu.beznea.uj@bp.renesas.com