From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8EF83822B9 for ; Mon, 16 Mar 2026 08:46:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773650815; cv=none; b=HdVRjZj3uu+IhHssO2OiFwiyBUSIl16vZ/W+uoNxgi+kfxSA7iUzDA8pBSo3DLe7XHOel2OVyD9dD1Hy3/CEI0G6OP6v5uiBe7bE4n7J9p2NCrq3JB1ycR/dwggMLuPQloUPHR1eo+OqJHcbpAnVEGPNl1xfOaGBAXjdCvPMo1s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773650815; c=relaxed/simple; bh=uzy3Nla4L7Nw+ktfD3Xv1LrZh4KNF1TVAyAovINCmFM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=hvyBMFr2pdVKDF0ChiwDCvNlOa05mYRvt/h6BFzQdLgdTxkitq+Q/WXKs6dCcu1KUnLAMbh4SznBSJYdg3duYWm92HqQ1A0kwCtx2/7/SHTmrxbhfltP9wMKM0rf3wl0gEqh/rEk4hjHt/WAMJVCL7iNNsR3XSSVqDk8qbn0L5M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=vWh34LfB; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="vWh34LfB" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id DCC381A2DD7; Mon, 16 Mar 2026 08:46:43 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id B12475FC4A; Mon, 16 Mar 2026 08:46:43 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 45045103683DF; Mon, 16 Mar 2026 09:46:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1773650803; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=uzy3Nla4L7Nw+ktfD3Xv1LrZh4KNF1TVAyAovINCmFM=; b=vWh34LfBL1MwPmo2Pc72pM5XDhHOe5wDRtlrH22UI8yMeKkBHYH7jQrZXjEtJjMW58xF8j hhb15gvPAw4uBx2LcNFWk2aHdamH+BwT0Zw7Lb9V4Sfk+v2fy0DkoQYXURSwSMdGhCQemy J0rkC65QUcDjxeycgwH6fqKtcvoAECrs6zOKlQo1i9Qyabm4709bV3nKGSBLAZemncoFnu qI+0ZkUIq8aheSp64IBriX9MqGylPrJIaP5ctf1tMc4RocG6xFpJlEcb7hh/6ph4YOgv83 bmK2k9Aosh4UKFoKYG6g3dXVe0pXS1MZNW9NEhmJHB1/6qC6xkMFcteCzUovww== From: Miquel Raynal To: Olivier Sobrie Cc: Michal Simek , Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Andrea Scian Subject: Re: [PATCH] mtd: rawnand: pl353: make sure optimal timings are applied In-Reply-To: <20260304211823.569972-1-olivier@sobrie.be> (Olivier Sobrie's message of "Wed, 4 Mar 2026 22:18:23 +0100") References: <20260304211823.569972-1-olivier@sobrie.be> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Mon, 16 Mar 2026 09:46:39 +0100 Message-ID: <87bjgogo0g.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Hello Olivier, + Andrea On 04/03/2026 at 22:18:23 +01, Olivier Sobrie wrote: > Timings of the nand are adjusted by pl35x_nfc_setup_interface() but > actually applied by the pl35x_nand_select_target() function. > If there is only one nand chip, the pl35x_nand_select_target() will only > apply the timings once since the test at its beginning will always be true > after the first call to this function. As a result, the hardware will > keep using the default timings set at boot to detect the nand chip, not > the optimal ones. > > With this patch, we program directly the new timings when > pl35x_nfc_setup_interface() is called. > > Signed-off-by: Olivier Sobrie Nice, this probably will deserve a Fixes tag and Cc: stable. Andrea, this might be the reason why your NAND chip misbehaves after a set_feature. Would you mind testing it? Thanks, Miqu=C3=A8l