From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E1ED175A76 for ; Sat, 28 Feb 2026 22:35:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772318138; cv=none; b=SPUsNSaztfR6B0XLy55LbP/2x8VOzFH56OlbaczGYZ3XUKx3Y+2T78fEukoQnZfnPsZO9PDUf1C1h/iQmxVp4L3iC1Qcf5DBsQGHQ5UEjx+PnE3a9/pViedHzs0nnJHPbsW6jFa00It4oJeLtId/2kw5FCx6dFL3sbJEKkmrh+c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772318138; c=relaxed/simple; bh=zdRJm8f7PCdFuhAhSf0cR35tOJ97cqkkty5z/SNZTtM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=Jp83i9bQRza0s+bWrMBsYC+DpegrkmYRXZIfGIUGri9xA9BLjNp3cdbVTj5HG+jIpSwPjdYvFPDzciEhFvsbNu1/p6y+OtK6ZsMyT49oCWUsvDxcatP/WEI5uIbpmj3JlVAlogedYwsBHrZumt9R6WJkQgPVilAr/4pcZpTPE80= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=rg+XJ8iO; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=FcrlCYds; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="rg+XJ8iO"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="FcrlCYds" From: John Ogness DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1772318135; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aIE9aLFeLZkM2WrCUSX9zq9LqnCsIqVKumv/4aW9pbE=; b=rg+XJ8iOvQ4okrnv2Cix6SkdU+e5zrz41ydoD/isVNbpTOX2+6CMx/oiYIf/r/szi+aBVf iqIg8U13u/qoHVAe993XjhaVaUa+Os1Gf/X6Lt4lDjByvpe6u2WtabuVI2QqFgWMOsUEvw r4NF2GRqo7pHFNGJX0uyeTHFDLxNYLiDMe22gYsqUVC7IE+vdOB5bxye+HKr8zvpL82Q/V 6mxeup7DIGG5mfN3tn2X3ZGYIQwAcFtyDE/hIQFlOJ0Wov6YnGUpcK5JRyT+nyix7hTWF9 Ek3rmv3EMvE+uw6UOrH2YagUHLgx+qYzNh1Bo2HYdyZp9Bdv3gwSdAJPvljXRg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1772318135; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aIE9aLFeLZkM2WrCUSX9zq9LqnCsIqVKumv/4aW9pbE=; b=FcrlCYds1B4jPH1974GQSYK4wf81kfEJF4vGB/3b0tkyMI2E49KiDx/35wRX0RJo5swmLc sZ7lXm7+XJTp/bAg== To: Takashi Sakamoto Cc: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: firewire-ohci: 7.0.0-rc1 warnings+crash In-Reply-To: <20260228031255.GA832746@workstation.local> References: <87tsv1vig5.fsf@jogness.linutronix.de> <20260228031255.GA832746@workstation.local> Date: Sat, 28 Feb 2026 23:41:34 +0106 Message-ID: <87bjh8ijih.fsf@jogness.linutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On 2026-02-28, Takashi Sakamoto wrote: > Thanks for the issue. It reports that the page array passed to vmap() > includes any entries which have invalid PFN. I realize that the page > array is passed to page_alloc_bulk() without zero initialization, thus > it could include any garbage values. > > Would I ask you to apply the following patch and the issue is still > regenerated or not? With the patch applied, everything is working again. Thanks! > ===== 8<- ----- > From 0d82ddae99869b231200d5247bbae586bf28274c Mon Sep 17 00:00:00 2001 > From: Takashi Sakamoto > Date: Sat, 28 Feb 2026 11:56:03 +0900 > Subject: [PATCH] firewire: ohci: initialize page array to use > alloc_pages_bulk() correctly > > The call of alloc_pages_bulk() skips to fill entries of page array when > the entries already have values. While, 1394 OHCI PCI driver passes the > page array without initializing. It could cause invalid state at PFN > validation in vmap(). > > Fixes: f2ae92780ab9 ("firewire: ohci: split page allocation from dma mapping") > Reported-by: John Ogness > Closes: https://lore.kernel.org/lkml/87tsv1vig5.fsf@jogness.linutronix.de/ > Signed-off-by: Takashi Sakamoto Tested-by: John Ogness