From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA8FD255E43 for ; Wed, 28 Jan 2026 14:11:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769609486; cv=none; b=D8PTEy0x0gc6Cjw19PaDqzllA3YyiSCNh/Qdvx3lbS5yoFmz9oyJ3IPaxB18rMyQdcqE166i9k7Zjh1f1X8fXK5sNphp/rViqPhSPPpu6MSACt5Q7vcGi6ukDhIVqLn5YxMZmd6ni+er1Rd4Ls3mMz73sCJJ4hdKM0xo02MZI/g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769609486; c=relaxed/simple; bh=kRRWCWxAwezRe/igPPO9pv+PEvWw27k6O+gOZnNIfGA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=sRb8QDynKZLfZi9wZYr5QoftwJgQubTJwc71rQGOIBljfIgHm5s7d/tpzK5S8Td3Vd7YPzBMa8yjcrSci26ndvcjHoIVpbD+aBXTO1OtUA9/cMhZxaf4c6DtUqA8LdDCyy3opU3vXXZrAC0f06eh0c9VTwxafq7CCo43XLQNUvM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=Hya5SHYr; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="Hya5SHYr" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 172FC4E4221B; Wed, 28 Jan 2026 14:11:22 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id C9D4C6071F; Wed, 28 Jan 2026 14:11:21 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 1F4D0119A880E; Wed, 28 Jan 2026 15:11:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1769609481; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=kRRWCWxAwezRe/igPPO9pv+PEvWw27k6O+gOZnNIfGA=; b=Hya5SHYrgfhz4uqrY21BH3TNjFVlN4mZDEzoTl8Zib/kwJFp5xm/liA+xe8pb+ZezLLlEB QqM7VhnYgqzMFUNP15BRtnaWLNkHnNbkQMnTPWgLzMa+1UDaM/5loJblvcOyT/ps0xaxg5 DPkVu68xIPHcQMG+yz7nfjFdcnFaNO6gVJgXef4w7Fr9+wREqfTG9XirCDTBIa4hY990wj H4QXJ6E+waN1HDiEhsQHWqHvQOv1F372ymlZDGmNi63KCIXb8JCuCaj0y3pjTlyjb2GEDm IYRjIWGmffANlWrx65vtCpIqsuzlaRAkATHPd7w8mrLwRgamYzi4lr+ZPG8bqA== From: Miquel Raynal To: Shiji Yang Cc: linux-mtd@lists.infradead.org, Tudor Ambarus , Pratyush Yadav , Michael Walle , Richard Weinberger , Vignesh Raghavendra , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mtd: spi-nor: swp: check SR_TB flag when getting tb_mask In-Reply-To: (Shiji Yang's message of "Wed, 28 Jan 2026 20:42:56 +0800") References: User-Agent: mu4e 1.12.7; emacs 30.2 Date: Wed, 28 Jan 2026 15:11:17 +0100 Message-ID: <87bjidn7y2.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 On 28/01/2026 at 20:42:56 +08, Shiji Yang wrote: > When the chip does not support top/bottom block protect, the tb_mask > must be set to 0, otherwise SR1 bit5 will be unexpectedly modified. > > Signed-off-by: Shiji Yang Good point. Reviewed-by: Miquel Raynal Thanks, Miqu=C3=A8l