public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Umang Jain <uajain@igalia.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Dmitry Baryshkov <lumag@kernel.org>,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-dev@igalia.com
Subject: Re: [PATCH] ALSA: pcm: Harden the spk_alloc assumption check
Date: Fri, 21 Nov 2025 10:35:17 +0100	[thread overview]
Message-ID: <87bjkv4tka.wl-tiwai@suse.de> (raw)
In-Reply-To: <20251120141757.901505-1-uajain@igalia.com>

On Thu, 20 Nov 2025 15:17:57 +0100,
Umang Jain wrote:
> 
> If the parsed ELD has spk_alloc=0, it currently assigns the parsed ELD
> spk_alloc to 0xffff. However, we should also check if there is at least
> one SAD (Short audio descriptor) to enforce the assumption, as ELD
> without any sad_count, is usually considered invalid for e.g. in
> commit ce9778b7a0272("ALSA: hda/hdmi: Consider ELD is invalid when no
> SAD is present").
> 
> Signed-off-by: Umang Jain <uajain@igalia.com>

Thanks, applied now.


Takashi

      reply	other threads:[~2025-11-21  9:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-20 14:17 [PATCH] ALSA: pcm: Harden the spk_alloc assumption check Umang Jain
2025-11-21  9:35 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bjkv4tka.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=kernel-dev@igalia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=lumag@kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --cc=uajain@igalia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox