From: Thomas Gleixner <tglx@linutronix.de>
To: "enlin.mu" <enlin.mu@linux.dev>,
anna-maria@linutronix.de, frederic@kernel.org,
linux-kernel@vger.kernel.org, enlin.mu@unisoc.com
Subject: Re: [PATCH V2] hrtimer: Check running timer state
Date: Mon, 17 Nov 2025 08:31:00 +0100 [thread overview]
Message-ID: <87bjl186a3.ffs@tglx> (raw)
In-Reply-To: <68734d1a-b77e-495e-922a-7fce3a122789@linux.dev>
On Mon, Nov 17 2025 at 07:58, enlin mu wrote:
> On 2025/11/15 02:34, Thomas Gleixner wrote:
> The serial_timer on cpu6 has not been properly cancelled.
> The serial_timer is once again entered into the active queue on cpu7.
> ---------------------------
> on cpu7
>
> step 1: preempted by hrtimer_usb
>
> static void __run_hrtimer(.....)
> {
> ......
> base->running = timer; //timer is serial_timer;
>
> .....
> .....
> restart = fn(timer); // fn is serial_timer_handler
> .... ==> irq is enable. serial_timer is preempted by hrtimer_usb
I told you before that enabling interrupts in the callback is
wrong. That's what needs to be fixed.
Run your experimental code with lockdep enabled. That will tell you
what's wrong.
Thanks,
tglx
prev parent reply other threads:[~2025-11-17 7:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 11:42 [PATCH V2] hrtimer: Check running timer state Enlin Mu
2025-11-14 18:34 ` Thomas Gleixner
2025-11-16 23:58 ` enlin.mu
2025-11-17 7:31 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bjl186a3.ffs@tglx \
--to=tglx@linutronix.de \
--cc=anna-maria@linutronix.de \
--cc=enlin.mu@linux.dev \
--cc=enlin.mu@unisoc.com \
--cc=frederic@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox