From: Thomas Gleixner <tglx@linutronix.de>
To: Li Chen <me@linux.beauty>, Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>, x86 <x86@kernel.org>,
"H . Peter Anvin" <hpa@zytor.com>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
K Prateek Nayak <kprateek.nayak@amd.com>,
Sohil Mehta <sohil.mehta@intel.com>,
Brian Gerst <brgerst@gmail.com>,
Patryk Wlazlyn <patryk.wlazlyn@linux.intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Li Chen <chenl311@chinatelecom.cn>
Subject: Re: [PATCH v3 1/2] x86/smpboot: Decrapify build_sched_topology()
Date: Mon, 30 Jun 2025 14:56:04 +0200 [thread overview]
Message-ID: <87bjq5o0bf.ffs@tglx> (raw)
In-Reply-To: <197be36341f.121c2d667978523.290703926590546064@linux.beauty>
On Mon, Jun 30 2025 at 08:21, Li Chen wrote:
> ---- On Wed, 25 Jun 2025 16:28:19 +0800 Peter Zijlstra <peterz@infradead.org> wrote ---
> > Urgh, this patch is doing at least 4 things and nigh on unreadable
> > because of that.
> >
> > - introduces DOMAIN() helper
> > - drops (the now pointless) SD_INIT_NAME() helper
> > - drops CONFIG_SCHED_SMT (x86 special)
> > - moves to static initialize and truncate
>
> Thanks for your review, I would split this Thomas's patch to 4 different patches
> and preserve his signoff
Nah. Just split it up and add
Suggested-by: Thomas ....
next prev parent reply other threads:[~2025-06-30 12:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-25 3:45 [PATCH v3 0/2] x86/smpboot: tidy sched-topology and drop useless SMT level Li Chen
2025-06-25 3:45 ` [PATCH v3 1/2] x86/smpboot: Decrapify build_sched_topology() Li Chen
2025-06-25 8:28 ` Peter Zijlstra
2025-06-30 0:21 ` Li Chen
2025-06-30 12:56 ` Thomas Gleixner [this message]
2025-06-25 3:45 ` [PATCH v3 2/2] x86/smpboot: avoid SMT domain attach/destroy if SMT is not enabled Li Chen
2025-06-25 5:45 ` K Prateek Nayak
2025-06-25 8:30 ` Peter Zijlstra
2025-06-30 0:39 ` Li Chen
2025-06-25 8:29 ` Peter Zijlstra
2025-06-30 0:29 ` Li Chen
2025-06-25 5:50 ` [PATCH v3 0/2] x86/smpboot: tidy sched-topology and drop useless SMT level K Prateek Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bjq5o0bf.ffs@tglx \
--to=tglx@linutronix.de \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=chenl311@chinatelecom.cn \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=me@linux.beauty \
--cc=mingo@redhat.com \
--cc=patryk.wlazlyn@linux.intel.com \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=sohil.mehta@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).