From: Esben Haabendal <esben@geanix.com>
To: "Matti Vaittinen" <mazziesaccount@gmail.com>
Cc: "Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regulator: bd718x7: Ensure SNVS power state is used as requested
Date: Thu, 08 May 2025 19:20:42 +0200 [thread overview]
Message-ID: <87bjs3auj9.fsf@geanix.com> (raw)
In-Reply-To: <54f3b79a-38d2-4760-ba1a-125172142255@gmail.com> (Matti Vaittinen's message of "Mon, 05 May 2025 09:07:03 +0300")
"Matti Vaittinen" <mazziesaccount@gmail.com> writes:
> On 03/05/2025 12:23, Esben Haabendal wrote:
>>
>> What do you think, should we leave it in the current state, or can we
>> figure out a way to allow the driver to actively change the watchdog
>> reset to go to SNVS power state?
>
> I can't really think of a safe way other than adding a new property.
>
> The IC is oldish, and AFACS, quite widely used. People seem to have
> found a way to make it work without (in-tree) feature for changing the
> reset target to the SNVS. I wouldn't try to implement this unless we
> have a use-case really requiring it. So, I'd suggest you to do it in
> boot. Still, if you have a valid case for this to be done in the driver
> - then I have no reason to object adding a new binding + support in the
> driver.
I have now implemted the PMIC setup in U-Boot, so am fine with dropping
the patch for now.
For anyone else finding this thread later on, the advice is to setup the
PMIC in bootloader or by some other low-level method. But if that for
some reason is not feasible, you can continue the work / discussion we
have had here in order to add a new binding + support in the driver for
it.
/Esben
prev parent reply other threads:[~2025-05-08 17:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-01 14:48 [PATCH] regulator: bd718x7: Ensure SNVS power state is used as requested Esben Haabendal
2025-05-02 5:24 ` Matti Vaittinen
2025-05-02 6:46 ` Esben Haabendal
2025-05-02 8:20 ` Matti Vaittinen
2025-05-03 9:23 ` Esben Haabendal
2025-05-05 6:07 ` Matti Vaittinen
2025-05-08 17:20 ` Esben Haabendal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bjs3auj9.fsf@geanix.com \
--to=esben@geanix.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox