From: Ankur Arora <ankur.a.arora@oracle.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Ankur Arora <ankur.a.arora@oracle.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org,
"Peter Zijlstra" <peterz@infradead.org>,
tglx@linutronix.de, mingo@kernel.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
bsegall@google.com, mgorman@suse.de, vschneid@redhat.com,
efault@gmx.de, Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Subject: Re: [PATCH 2/3] tracing: Record task flag NEED_RESCHED_LAZY.
Date: Wed, 09 Oct 2024 11:49:41 -0700 [thread overview]
Message-ID: <87bjztaz7e.fsf@oracle.com> (raw)
In-Reply-To: <20241009133328.23fc671c@gandalf.local.home>
Steven Rostedt <rostedt@goodmis.org> writes:
> On Wed, 09 Oct 2024 10:30:28 -0700
> Ankur Arora <ankur.a.arora@oracle.com> wrote:
>
>> > +++ b/kernel/trace/trace.c
>> > @@ -2544,6 +2544,8 @@ unsigned int tracing_gen_ctx_irq_test(unsigned int irqs_status)
>> > trace_flags |= TRACE_FLAG_NEED_RESCHED;
>> > if (test_preempt_need_resched())
>> > trace_flags |= TRACE_FLAG_PREEMPT_RESCHED;
>> > + if (tif_test_bit(TIF_NEED_RESCHED_LAZY))
>>
>> TIF_NEED_RESCHED_LAZY falls back to TIF_NEED_RESCHED without
>> CONFIG_ARCH_HAS_PREEMPT_LAZY. So, you might need to add an explicit
>> check for that as well.
>>
>> With that,
>> Reviewed-by: Ankur Arora <ankur.a.arora@oracle.com>
>>
>> Ankur
>>
>
> So this should be:
>
> if (IS_ENABLED(CONFIG_ARCH_HAS_PREEMPT_LAZY) &&
> tif_test_bit(TIF_NEED_RESCHED_LAZY))
>
> ?
Yeah, exactly that.
--
ankur
next prev parent reply other threads:[~2024-10-09 18:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 10:50 [PATCH 0/3] Lazy preemption leftovers Sebastian Andrzej Siewior
2024-10-09 10:50 ` [PATCH 1/3] tracing: Replace TRACE_FLAG_IRQS_NOSUPPORT with its config option Sebastian Andrzej Siewior
2024-10-09 10:50 ` [PATCH 2/3] tracing: Record task flag NEED_RESCHED_LAZY Sebastian Andrzej Siewior
2024-10-09 14:25 ` Steven Rostedt
2024-10-09 17:30 ` Ankur Arora
2024-10-09 17:33 ` Steven Rostedt
2024-10-09 18:49 ` Ankur Arora [this message]
2024-10-10 10:56 ` Sebastian Andrzej Siewior
2024-10-10 14:52 ` Steven Rostedt
2024-10-10 14:55 ` Sebastian Andrzej Siewior
2024-10-16 9:17 ` Shrikanth Hegde
2024-10-09 10:50 ` [PATCH 3/3] riscv: add PREEMPT_LAZY support Sebastian Andrzej Siewior
2024-10-09 13:03 ` Peter Zijlstra
2024-10-09 13:05 ` Sebastian Andrzej Siewior
2024-10-17 21:49 ` Palmer Dabbelt
2024-10-10 12:25 ` [PATCH v2 " Sebastian Andrzej Siewior
2024-12-11 22:32 ` patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bjztaz7e.fsf@oracle.com \
--to=ankur.a.arora@oracle.com \
--cc=bigeasy@linutronix.de \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=efault@gmx.de \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mgorman@suse.de \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox