From: Takashi Iwai <tiwai@suse.de>
To: Mark Brown <broonie@kernel.org>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Shuah Khan <shuah@kernel.org>,
linux-sound@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kselftest/alsa: Fix validation of writes to volatile controls
Date: Sun, 16 Jun 2024 09:32:24 +0200 [thread overview]
Message-ID: <87bk415omv.wl-tiwai@suse.de> (raw)
In-Reply-To: <20240614-alsa-selftest-volatile-v1-1-3874f02964b1@kernel.org>
On Fri, 14 Jun 2024 18:40:37 +0200,
Mark Brown wrote:
>
> When validating writes to controls we check that whatever value we wrote
> actually appears in the control. For volatile controls we cannot assume
> that this will be the case, the value may be changed at any time
> including between our write and read. Handle this by moving the check
> for volatile controls that we currently do for events to a separate
> block and just verifying that whatever value we read is valid for the
> control.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
I'll pick this in v3 patch set.
thanks,
Takashi
prev parent reply other threads:[~2024-06-16 7:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 16:40 [PATCH] kselftest/alsa: Fix validation of writes to volatile controls Mark Brown
2024-06-16 7:32 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bk415omv.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=shuah@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox