[PATCH 1/1] sound: Support microphone from device Acer 315-24p

[PATCH 1/1] sound: Support microphone from device Acer 315-24p

[end.to.start]

This patch adds microphone detection for the Acer 315-24p, after which a microphone appears on the device and starts working

Signed-off-by: end.to.start <end.to.start@mail.ru>
---
 sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
index 69c68d8e7..1760b5d42 100644
--- a/sound/soc/amd/yc/acp6x-mach.c
+++ b/sound/soc/amd/yc/acp6x-mach.c
@@ -430,6 +430,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
 			DMI_MATCH(DMI_BOARD_NAME, "MRID6"),
 		}
 	},
+	{
+		.driver_data = &acp6x_card,
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "MDC"),
+			DMI_MATCH(DMI_BOARD_NAME, "Herbag_MDU"),
+		}
+	},
 	{
 		.driver_data = &acp6x_card,
 		.matches = {
-- 
2.44.0

[PATCH 1/1] sound: Support microphone from device Acer 315-24p

[end.to.start]

This patch adds microphone detection for the Acer 315-24p, after which a microphone appears on the device and starts working

Signed-off-by: end.to.start <end.to.start@mail.ru>
---
 sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
index 69c68d8e7..1760b5d42 100644
--- a/sound/soc/amd/yc/acp6x-mach.c
+++ b/sound/soc/amd/yc/acp6x-mach.c
@@ -430,6 +430,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
 			DMI_MATCH(DMI_BOARD_NAME, "MRID6"),
 		}
 	},
+	{
+		.driver_data = &acp6x_card,
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "MDC"),
+			DMI_MATCH(DMI_BOARD_NAME, "Herbag_MDU"),
+		}
+	},
 	{
 		.driver_data = &acp6x_card,
 		.matches = {
-- 
2.44.0

[PATCH 1/1] sound: Support microphone from device Acer 315-24p

[end.to.start]

This patch adds microphone detection for the Acer 315-24p, after which a microphone appears on the device and starts working

Signed-off-by: end.to.start <end.to.start@mail.ru>
---
 sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
index 69c68d8e7..1760b5d42 100644
--- a/sound/soc/amd/yc/acp6x-mach.c
+++ b/sound/soc/amd/yc/acp6x-mach.c
@@ -430,6 +430,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
 			DMI_MATCH(DMI_BOARD_NAME, "MRID6"),
 		}
 	},
+	{
+		.driver_data = &acp6x_card,
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "MDC"),
+			DMI_MATCH(DMI_BOARD_NAME, "Herbag_MDU"),
+		}
+	},
 	{
 		.driver_data = &acp6x_card,
 		.matches = {
-- 
2.44.0

Re: [PATCH 1/1] sound: Support microphone from device Acer 315-24p

[Mark Brown]

On Mon, 08 Apr 2024 18:24:54 +0300, end.to.start wrote:
> This patch adds microphone detection for the Acer 315-24p, after which a microphone appears on the device and starts working
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] sound: Support microphone from device Acer 315-24p
      commit: 4b9a474c7c820391c0913d64431ae9e1f52a5143

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

Re: [PATCH 1/1] sound: Support microphone from device Acer 315-24p

[Jaroslav Kysela]

On 09. 04. 24 20:08, Mark Brown wrote:
> On Mon, 08 Apr 2024 18:24:54 +0300, end.to.start wrote:
>> This patch adds microphone detection for the Acer 315-24p, after which a microphone appears on the device and starts working
>>
>>
> 
> Applied to
> 
>     https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
> 
> Thanks!
> 
> [1/1] sound: Support microphone from device Acer 315-24p
>        commit: 4b9a474c7c820391c0913d64431ae9e1f52a5143
> 
> All being well this means that it will be integrated into the linux-next
> tree (usually sometime in the next 24 hours) and sent to Linus during
> the next merge window (or sooner if it is a bug fix), however if
> problems are discovered then the patch may be dropped or reverted.

Shall we really accept those anonymous contributions?

 From submitting-patches.rst:

"""
then you just add a line saying::

         Signed-off-by: Random J Developer <random@developer.example.org>

using a known identity (sorry, no anonymous contributions.)
"""

					Jaroslav

-- 
Jaroslav Kysela <perex@perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.

Re: [PATCH 1/1] sound: Support microphone from device Acer 315-24p

[Takashi Iwai]

On Fri, 03 May 2024 13:23:28 +0200,
Jaroslav Kysela wrote:
> 
> On 09. 04. 24 20:08, Mark Brown wrote:
> > On Mon, 08 Apr 2024 18:24:54 +0300, end.to.start wrote:
> >> This patch adds microphone detection for the Acer 315-24p, after which a microphone appears on the device and starts working
> >> 
> >> 
> > 
> > Applied to
> > 
> >     https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
> > 
> > Thanks!
> > 
> > [1/1] sound: Support microphone from device Acer 315-24p
> >        commit: 4b9a474c7c820391c0913d64431ae9e1f52a5143
> > 
> > All being well this means that it will be integrated into the linux-next
> > tree (usually sometime in the next 24 hours) and sent to Linus during
> > the next merge window (or sooner if it is a bug fix), however if
> > problems are discovered then the patch may be dropped or reverted.
> 
> Shall we really accept those anonymous contributions?
> 
> From submitting-patches.rst:
> 
> """
> then you just add a line saying::
> 
>         Signed-off-by: Random J Developer <random@developer.example.org>
> 
> using a known identity (sorry, no anonymous contributions.)
> """

Yeah, that's a bad example, and I noticed too late after sending a PR
to Linus, too (I concentrated only on the diffs).

The code change itself looks OK, so this is no big problem.
But let's decline such a submission at the next time.


thanks,

Takashi

Re: [PATCH 1/1] sound: Support microphone from device Acer 315-24p

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 510 bytes --]

On Fri, May 03, 2024 at 01:23:28PM +0200, Jaroslav Kysela wrote:
> On 09. 04. 24 20:08, Mark Brown wrote:
> > On Mon, 08 Apr 2024 18:24:54 +0300, end.to.start wrote:

> > [1/1] sound: Support microphone from device Acer 315-24p
> >        commit: 4b9a474c7c820391c0913d64431ae9e1f52a5143

> Shall we really accept those anonymous contributions?

I was on the edge here, what pushed me towards accepting it was that the
change was just a data based quirk addition which is almost if not quite
a trivial change.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]