* [PATCH] drm/i915: add intel_opregion_vbt_present() stub function
@ 2024-03-13 8:47 Arnd Bergmann
2024-03-13 9:53 ` Jani Nikula
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2024-03-13 8:47 UTC (permalink / raw)
To: Jani Nikula, Rodrigo Vivi, Joonas Lahtinen, Tvrtko Ursulin,
David Airlie, Daniel Vetter, Radhakrishna Sripada
Cc: Arnd Bergmann, Imre Deak, Nirmoy Das, intel-gfx, intel-xe,
dri-devel, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The newly added function is not available without CONFIG_ACPI, causing
a build failure:
drivers/gpu/drm/i915/display/intel_bios.c:3424:24: error: implicit declaration of function 'intel_opregion_vbt_present'; did you mean 'intel_opregion_asle_present'? [-Werror=implicit-function-declaration]
Add an empty stub in the same place as the other stubs.
Fixes: 9d9bb71f3e11 ("drm/i915: Extract opregion vbt presence check")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpu/drm/i915/display/intel_opregion.h | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_opregion.h b/drivers/gpu/drm/i915/display/intel_opregion.h
index 63573c38d735..4b2b8e752632 100644
--- a/drivers/gpu/drm/i915/display/intel_opregion.h
+++ b/drivers/gpu/drm/i915/display/intel_opregion.h
@@ -120,6 +120,11 @@ intel_opregion_get_edid(struct intel_connector *connector)
return NULL;
}
+static inline bool intel_opregion_vbt_present(struct drm_i915_private *i915)
+{
+ return false;
+}
+
static inline const void *
intel_opregion_get_vbt(struct drm_i915_private *i915, size_t *size)
{
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/i915: add intel_opregion_vbt_present() stub function
2024-03-13 8:47 [PATCH] drm/i915: add intel_opregion_vbt_present() stub function Arnd Bergmann
@ 2024-03-13 9:53 ` Jani Nikula
0 siblings, 0 replies; 2+ messages in thread
From: Jani Nikula @ 2024-03-13 9:53 UTC (permalink / raw)
To: Arnd Bergmann, Rodrigo Vivi, Joonas Lahtinen, Tvrtko Ursulin,
David Airlie, Daniel Vetter, Radhakrishna Sripada
Cc: Arnd Bergmann, Imre Deak, Nirmoy Das, intel-gfx, intel-xe,
dri-devel, linux-kernel
On Wed, 13 Mar 2024, Arnd Bergmann <arnd@kernel.org> wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The newly added function is not available without CONFIG_ACPI, causing
> a build failure:
>
> drivers/gpu/drm/i915/display/intel_bios.c:3424:24: error: implicit declaration of function 'intel_opregion_vbt_present'; did you mean 'intel_opregion_asle_present'? [-Werror=implicit-function-declaration]
>
> Add an empty stub in the same place as the other stubs.
>
> Fixes: 9d9bb71f3e11 ("drm/i915: Extract opregion vbt presence check")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks, but just applied the identical [1].
BR,
Jani.
[1] https://lore.kernel.org/r/20240312115757.683584-1-jani.nikula@intel.com
> ---
> drivers/gpu/drm/i915/display/intel_opregion.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_opregion.h b/drivers/gpu/drm/i915/display/intel_opregion.h
> index 63573c38d735..4b2b8e752632 100644
> --- a/drivers/gpu/drm/i915/display/intel_opregion.h
> +++ b/drivers/gpu/drm/i915/display/intel_opregion.h
> @@ -120,6 +120,11 @@ intel_opregion_get_edid(struct intel_connector *connector)
> return NULL;
> }
>
> +static inline bool intel_opregion_vbt_present(struct drm_i915_private *i915)
> +{
> + return false;
> +}
> +
> static inline const void *
> intel_opregion_get_vbt(struct drm_i915_private *i915, size_t *size)
> {
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-13 9:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-13 8:47 [PATCH] drm/i915: add intel_opregion_vbt_present() stub function Arnd Bergmann
2024-03-13 9:53 ` Jani Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox