Re: [PATCH 00/10] vdso: Misc cleanups and prevent code duplication

[Anna-Maria Behnsen <anna-maria@linutronix.de>]

Kees Cook <keescook@chromium.org> writes:

> On Mon, Feb 19, 2024 at 04:39:29PM +0100, Anna-Maria Behnsen wrote:
>> Hi,
>> 
>> the vdso related cleanup queue contains two parts:
>> 
>> - Patch 1-3: Misc cleanups related to a comment, a superfluous header
>> 	     include and ifdeffery
>> 
>> - Patch 4-10: The union vdso_data_store is defined in seven
>>   	      architectures. Make this union available in a generic vdso
>>   	      header file to prevent code duplication and fix the
>>   	      architectures one by one to use the generic vdso_data_store.
>> 
>> Thanks,
>> 
>> 	Anna-Maria
>
> I do love a good clean-up! Thanks for this, I looked through all the
> patches and they seem correct to me;

Thank you! I had a mistake in there and already posted a new version for
this single patch - I forgot to update this patch before posting...

> removed definitions are all
> identical, and __page_aligned_data is kept where needed.
>
> Reviewed-by: Kees Cook <keescook@chromium.org>
>
> -Kees

Thanks,

	Anna-Maria