From: Thomas Gleixner <tglx@linutronix.de>
To: Vidya Sagar <vidyas@nvidia.com>,
bhelgaas@google.com, rdunlap@infradead.org,
ilpo.jarvinen@linux.intel.com, jiang.liu@linux.intel.com
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
treding@nvidia.com, jonathanh@nvidia.com, sdonthineni@nvidia.com,
kthota@nvidia.com, mmaddireddy@nvidia.com, vidyas@nvidia.com,
sagar.tv@gmail.com
Subject: Re: [PATCH V3] PCI/MSI: Fix MSI hwirq truncation
Date: Fri, 12 Jan 2024 16:53:26 +0100 [thread overview]
Message-ID: <87bk9qim4p.ffs@tglx> (raw)
In-Reply-To: <20240111052814.713016-1-vidyas@nvidia.com>
On Thu, Jan 11 2024 at 10:58, Vidya Sagar wrote:
> While calculating the hwirq number for an MSI interrupt, the higher
> bits (i.e. from bit-5 onwards a.k.a domain_nr >= 32) of the PCI domain
> number gets truncated because of the shifted value casting to return
> type of pci_domain_nr() which is 'int'. This for example is resulting
> in same hwirq number for devices 0019:00:00.0 and 0039:00:00.0.
>
> So, cast the PCI domain number to 'irq_hw_number_t' before left shifting
> it to calculate hwirq number.
This still does not explain that this fixes it only on 64-bit platforms
and why we don't care for 32-bit systems.
next prev parent reply other threads:[~2024-01-12 15:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-05 13:43 [PATCH V1] PCI/MSI: Fix MSI hwirq truncation Vidya Sagar
2024-01-05 17:02 ` Kuppuswamy Sathyanarayanan
2024-01-08 11:58 ` Vidya Sagar
2024-01-08 12:05 ` [PATCH V2] " Vidya Sagar
2024-01-08 14:09 ` Shanker Donthineni
2024-01-10 10:12 ` Thomas Gleixner
2024-01-10 18:04 ` Vidya Sagar
2024-01-11 5:28 ` [PATCH V3] " Vidya Sagar
2024-01-12 15:53 ` Thomas Gleixner [this message]
2024-01-12 17:33 ` Vidya Sagar
2024-01-15 10:01 ` Thomas Gleixner
2024-01-15 13:50 ` Vidya Sagar
2024-01-15 13:56 ` [PATCH V4] " Vidya Sagar
2024-01-23 16:01 ` Vidya Sagar
2024-01-31 3:15 ` Vidya Sagar
2024-02-07 6:59 ` Vidya Sagar
2024-02-07 10:01 ` Thomas Gleixner
2024-02-19 15:21 ` [tip: irq/urgent] PCI/MSI: Prevent MSI hardware interrupt number truncation tip-bot2 for Vidya Sagar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bk9qim4p.ffs@tglx \
--to=tglx@linutronix.de \
--cc=bhelgaas@google.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jiang.liu@linux.intel.com \
--cc=jonathanh@nvidia.com \
--cc=kthota@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mmaddireddy@nvidia.com \
--cc=rdunlap@infradead.org \
--cc=sagar.tv@gmail.com \
--cc=sdonthineni@nvidia.com \
--cc=treding@nvidia.com \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox