From: Gabriel Krisman Bertazi <krisman@suse.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Markus Elfring <Markus.Elfring@web.de>,
io-uring@vger.kernel.org, kernel-janitors@vger.kernel.org,
Pavel Begunkov <asml.silence@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] io_uring: Delete a redundant kfree() call in io_ring_ctx_alloc()
Date: Fri, 12 Jan 2024 14:15:47 -0300 [thread overview]
Message-ID: <87bk9qjwvw.fsf@mailhost.krisman.be> (raw)
In-Reply-To: <c17648db-469c-4d3c-8c2e-774b88e79f07@kernel.dk> (Jens Axboe's message of "Fri, 12 Jan 2024 09:18:44 -0700")
Jens Axboe <axboe@kernel.dk> writes:
> On 1/12/24 7:25 AM, Gabriel Krisman Bertazi wrote:
>> Markus Elfring <Markus.Elfring@web.de> writes:
>>
>>> From: Markus Elfring <elfring@users.sourceforge.net>
>>> Date: Wed, 10 Jan 2024 20:54:43 +0100
>>>
>>> Another useful pointer was not reassigned to the data structure member
>>> ?io_bl? by this function implementation.
>>> Thus omit a redundant call of the function ?kfree? at the end.
>
> This is just nonsense...
>
> On top of that, this patch is pointless, and the 2nd patch is even worse
> in that it just makes a mess of cleanup. And for what reasoning?
> Absolutely none.
Ah, The description is non-sense, but the change in this patch seemed
correct to me, even if pointless, which is why I reviewed it. patch 2
is just garbage.
> There's a reason why I filter emails from this particular author
> straight to the trash, there's a long history of this kind of thing and
> not understanding feedback.
Clearly there is background with this author that I wasn't aware, and
just based on his responses, I can see your point. So I apologize for
giving him space to continue the spamming. My bad.
--
Gabriel Krisman Bertazi
next prev parent reply other threads:[~2024-01-12 17:15 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <6cbcf640-55e5-2f11-4a09-716fe681c0d2@web.de>
[not found] ` <d33ebeca-0900-8c6c-ac44-f301daf24a5b@web.de>
2023-04-09 23:15 ` [PATCH] apparmor: Return directly after a failed kzalloc() in two functions John Johansen
[not found] ` <f1712777-97ff-d89c-0bdd-d72faed9a7f1@web.de>
2024-01-05 20:32 ` [PATCH] squashfs: Improve exception handling in squashfs_decompressor_create() Markus Elfring
[not found] ` <33226beb-4fe2-3da5-5d69-a33e683dec57@web.de>
2024-01-10 11:40 ` [PATCH 0/3] lru_cache: Adjustments for lc_create() Markus Elfring
[not found] ` <d9c673f9-2c32-282f-f261-b4d5762409bb@web.de>
2024-01-10 11:45 ` [PATCH 0/2] perf/x86/intel/pt: Adjustments for pt_pmu_hw_init() Markus Elfring
[not found] ` <562a6f99-3f8e-9a77-e519-b668e24dced2@web.de>
2024-01-10 11:48 ` [PATCH 0/2] ARM: Adjustments for init_atags_procfs() Markus Elfring
2024-01-10 11:52 ` [0/2] " Markus Elfring
2024-01-10 12:24 ` Russell King (Oracle)
2024-01-10 12:44 ` Markus Elfring
2024-01-10 12:47 ` Russell King (Oracle)
2024-01-10 12:52 ` Markus Elfring
2024-01-10 13:50 ` Russell King (Oracle)
2024-01-10 14:00 ` Markus Elfring
2024-01-10 14:07 ` Russell King (Oracle)
2024-01-10 13:34 ` Christian Heusel
2024-01-10 13:46 ` Markus Elfring
[not found] ` <87b65f8e-abde-2aff-4da8-df6e0b464677@web.de>
2024-01-10 12:24 ` [PATCH 0/4] overlayfs: Adjustments for ovl_fill_super() Markus Elfring
2024-01-10 12:49 ` Amir Goldstein
2024-01-10 13:01 ` [0/4] " Markus Elfring
2024-01-10 13:19 ` Amir Goldstein
2024-01-10 13:33 ` Markus Elfring
2024-01-10 13:45 ` Amir Goldstein
[not found] ` <aa867594-e79d-6d08-a08e-8c9e952b4724@web.de>
2024-01-10 11:23 ` io_uring: Fix exception handling in io_ring_ctx_alloc() Markus Elfring
2024-01-10 16:55 ` [cocci] [PATCH] " Gabriel Krisman Bertazi
2024-01-10 20:45 ` [PATCH v2 0/2] io_uring: Adjustments for io_ring_ctx_alloc() Markus Elfring
2024-01-10 20:48 ` [PATCH v2 1/2] io_uring: Delete a redundant kfree() call in io_ring_ctx_alloc() Markus Elfring
2024-01-12 14:25 ` Gabriel Krisman Bertazi
2024-01-12 16:18 ` Jens Axboe
2024-01-12 17:15 ` Gabriel Krisman Bertazi [this message]
2024-01-12 17:50 ` [v2 " Markus Elfring
2024-01-10 20:50 ` [PATCH v2 2/2] io_uring: Improve exception handling " Markus Elfring
2024-01-11 13:23 ` Pavel Begunkov
2024-01-12 14:30 ` Gabriel Krisman Bertazi
2024-01-12 15:00 ` [v2 " Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bk9qjwvw.fsf@mailhost.krisman.be \
--to=krisman@suse.de \
--cc=Markus.Elfring@web.de \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox