public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: 黄少波 <huangshaobo3@xiaomi.com>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Ahmed S. Darwish" <darwi@linutronix.de>,
	"Jason Gunthorpe" <jgg@ziepe.ca>,
	"Kevin Tian" <kevin.tian@intel.com>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: 李高鹏 <chenwei29@xiaomi.com>, 梁伟鹏 <weipengliang@xiaomi.com>,
	翁金飞 <wengjinfei@xiaomi.com>, 熊亮 <xiongliang@xiaomi.com>
Subject: Re: Subject: [PATCH] pci/msi: remove redundant calculation in msi_setup_msi_desc
Date: Wed, 23 Aug 2023 16:15:27 +0200	[thread overview]
Message-ID: <87bkexetfk.ffs@tglx> (raw)
In-Reply-To: <3ebf5d8032ad418da4f24516cd23406e@xiaomi.com>

On Fri, Aug 18 2023 at 07:26, 黄少波 wrote:

Your patch is corrupt:

 Applying: Subject: [PATCH] pci/msi: remove redundant calculation in msi_setup_msi_desc
 error: corrupt patch at line 12

It's DOS mangled and whitespace damaged.

> Whether to support 64-bit address status has been calculated before,
> and the calculation result can be used directly afterwards, so use
> msi_attrib.is_64 to avoid double calculation.

I'm not seeing what this solves:

> -       if (control & PCI_MSI_FLAGS_64BIT)
> +       if (desc.pci.msi_attrib.is_64)

Both variants resolve to a test of a bit and a conditional instruction
on the result. It's exactly zero difference in terms of "calculation".

So all this does is change the memory location to test. Not more not
less. It does not generate better code and does not save anything.

Thanks,

        tglx


  parent reply	other threads:[~2023-08-23 14:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-18  7:26 Subject: [PATCH] pci/msi: remove redundant calculation in msi_setup_msi_desc 黄少波
2023-08-18  8:30 ` Ilpo Järvinen
2023-08-23 14:15 ` Thomas Gleixner [this message]
2023-08-24  7:27   ` huangshaobo3
2023-08-24  9:04     ` Thomas Gleixner
2023-08-24 10:52       ` sparkhuang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bkexetfk.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=bhelgaas@google.com \
    --cc=chenwei29@xiaomi.com \
    --cc=darwi@linutronix.de \
    --cc=huangshaobo3@xiaomi.com \
    --cc=jgg@ziepe.ca \
    --cc=kevin.tian@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=weipengliang@xiaomi.com \
    --cc=wengjinfei@xiaomi.com \
    --cc=xiongliang@xiaomi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox