From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 707CBEB64DD
	for <linux-kernel@archiver.kernel.org>; Tue,  1 Aug 2023 08:54:49 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S232259AbjHAIyr (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Tue, 1 Aug 2023 04:54:47 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53812 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S231786AbjHAIya (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 1 Aug 2023 04:54:30 -0400
Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0F2B1726
        for <linux-kernel@vger.kernel.org>; Tue,  1 Aug 2023 01:54:24 -0700 (PDT)
From:   Thomas Gleixner <tglx@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
        s=2020; t=1690880063;
        h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
         to:to:cc:cc:mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=5D/H/wtmV/2qMq2QlRtxqoE9K4Ef5Ua0CblWkkulSQ0=;
        b=ubzdhhhXOBYbfHmWQdGXAGjwChIy3ujG9yl088QWX5MJ9DWP8Q3oDPM5XqwrcQ+uNapOUG
        i20ap5dpgfBVV+iVyFAljIcFrGuxJM5ZIhMPScnGZBt3rnnlznGorz5PIOima/tVxFZduI
        Trr0lLGsm/BFQeT2b7T5tkj+JHf3XpcH+fh25qZl1HlhoG5WaisCBElk7M/tDR7O4WPWAA
        n2QMFvbfyuXmIR953j6xRADi092HyRKPg8kHR6apjmwc7hWGWhZYoIINU3TvrDozQcivxR
        AYeOjONJVyy4NVA7hMP3dKufcLJOH93LRV7IKdq4GXJUt+8kaQ2GWjdaqTJN4w==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
        s=2020e; t=1690880063;
        h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
         to:to:cc:cc:mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=5D/H/wtmV/2qMq2QlRtxqoE9K4Ef5Ua0CblWkkulSQ0=;
        b=cdHh0xpPt+AA35zj8WMiIlXxG2TPFGEfD94/Ry3QjbsLG98PD6o46e9+JZ3fxa2+V2VKIn
        XL8vwqf1A3sxTUDA==
To:     Juergen Gross <jgross@suse.com>,
        LKML <linux-kernel@vger.kernel.org>
Cc:     x86@kernel.org, Andrew Cooper <andrew.cooper3@citrix.com>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Wei Liu <wei.liu@kernel.org>,
        Arjan van de Ven <arjan@linux.intel.com>,
        Michael Kelley <mikelley@microsoft.com>,
        Peter Keresztes Schmidt <peter@keresztesschmidt.de>,
        "Peter Zijlstra (Intel)" <peterz@infradead.org>
Subject: Re: [patch V2 50/58] x86/apic: Provide common init infrastructure
In-Reply-To: <bd5a43b8-c07d-c906-c0ef-ac8b3ae537e2@suse.com>
References: <20230724131206.500814398@linutronix.de>
 <20230724132047.554355840@linutronix.de>
 <abfa4548-4367-d8fa-f23f-b2ca4a912258@suse.com> <87v8e0nskd.ffs@tglx>
 <b4f0e874-1e35-e523-8e5a-710bc54af52d@suse.com> <87pm48nktc.ffs@tglx>
 <87v8dzl0wm.ffs@tglx> <807ac0ad-b2c4-4a10-a82c-6d95649ae4dc@suse.com>
 <f0d5b71b-4344-2f35-03ee-3af6ebd038b2@suse.com> <87o7jrkyjf.ffs@tglx>
 <3af74b7a-be7f-3fdb-396e-e76b8ca1efaf@suse.com> <87il9zkw7h.ffs@tglx>
 <bd5a43b8-c07d-c906-c0ef-ac8b3ae537e2@suse.com>
Date:   Tue, 01 Aug 2023 10:54:22 +0200
Message-ID: <87bkfrkurl.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Aug 01 2023 at 10:25, Juergen Gross wrote:
> On 01.08.23 10:23, Thomas Gleixner wrote:
>> On Tue, Aug 01 2023 at 09:37, Juergen Gross wrote:
>>> On 01.08.23 09:32, Thomas Gleixner wrote:
>>>> On Tue, Aug 01 2023 at 09:08, Juergen Gross wrote:
>>>>> On 01.08.23 08:49, Juergen Gross wrote:
>>>>>     void __init xen_init_apic(void)
>>>>>     {
>>>>>            x86_apic_ops.io_apic_read = xen_io_apic_read;
>>>>> -       /* On PV guests the APIC CPUID bit is disabled so none of the
>>>>> -        * routines end up executing. */
>>>>> -       if (!xen_initial_domain())
>>>>> -               apic_install_driver(&xen_pv_apic);
>>>>> -
>>>>>            x86_platform.apic_post_init = xen_apic_check;
>>>>
>>>> I don't think this one is needed.
>>>
>>> Indeed.
>> 
>> Can you send a real patch please which I can add to that pile at the
>> right place?
>
> I think adding it right after patch 50 should be fine?
>
> The WARN() will be issued only with patch 58.

Correct.