From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C356C001B0 for ; Mon, 3 Jul 2023 08:01:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231180AbjGCIB2 (ORCPT ); Mon, 3 Jul 2023 04:01:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230381AbjGCIBE (ORCPT ); Mon, 3 Jul 2023 04:01:04 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3FA27E59 for ; Mon, 3 Jul 2023 01:01:03 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 896EC2183A; Mon, 3 Jul 2023 08:01:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1688371261; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v91YPwHlpWACpU8s3O32vlR2gOHpnpt2E5fFBe+wPsU=; b=k2U+3X/HGGRdhEj2WhniGxLHpnGUWbTNzf0/S07XP4uhUllqwZ+sZ6n08JgR58Lv6NF1Xz DrOUtFmLeStGVANX9pU+N6qmPCkOfPkYNC5lJrfR86vt2lLONWHTVvPYp+3Jv291KF+v/v +O/K2J5kOYTxze3za0j5riMO40rCdYw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1688371261; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v91YPwHlpWACpU8s3O32vlR2gOHpnpt2E5fFBe+wPsU=; b=/ItMo2c0RrXR5sZHZcOzShIuhSrGLgAy5kHLt5xRBCRosCfDjtjQOlzDqdisLh1rtM/Pt0 CSby1F+aS8ACItCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5D204138FC; Mon, 3 Jul 2023 08:01:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id c0jNFT2AomQfZQAAMHmgww (envelope-from ); Mon, 03 Jul 2023 08:01:01 +0000 Date: Mon, 03 Jul 2023 10:01:00 +0200 Message-ID: <87bkgt77b7.wl-tiwai@suse.de> From: Takashi Iwai To: dengxiang Cc: tiwai@suse.com, yangyingliang@huawei.com, perex@perex.cz, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5] ALSA: hda/realtek: Add quirks for Unis H3C Desktop B760 & Q760 In-Reply-To: <20230703021751.2945750-1-dengxiang@nfschina.com> References: <20230703021751.2945750-1-dengxiang@nfschina.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 03 Jul 2023 04:17:51 +0200, dengxiang wrote: > > These models use NSIWAY amplifiers for internal speaker, but cannot put > sound outside from these amplifiers. So eapd verbs are needed to initialize > the amplifiers. They can be added during boot to get working sound out > of internal speaker. > > --- > V5: > - remove pci ssid 0x10ec0897 for specific unis device. > V4: > - put at the right position to keep the PCI SSID order for the whole. > V3: > - do some adjustment for eapd verbs and keep the capital letters for > ALC_* enums. > v2: > - remove warning about unused variable 'spec'. > > Signed-off-by: dengxiang Applied now, but I had to edit manually to move this Signed-off-by line. As mentioned in the previous post, the Signed-off-by line must be *before* the line "---"; git-am truncates the lines after "---", so Signed-off-by tag will be missing otherwise. Please put at the right position at the next time. thanks, Takashi